Selur's Little Message Board

Full Version: ProPainter Vapoursynth filter
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18
Replacing:
Code:
if clip.format.bits_per_sample != 8: clip = vs.core.resize.Bicubic(clip, format=clip.format.replace(bits_per_sample=8))
with:
Code:
if clip.format.bits_per_sample != 8: if clip.format.sample_type == vs.FLOAT: clip = vs.core.resize.Bicubic(clip, format=vs.RGB24, range_s="full") else: clip = vs.core.resize.Bicubic(clip, format=clip.format.replace(bits_per_sample=8))
does seem to fix the problem. (in propainter_utils.py)
Hi Selur,

  could you clarify better the problem ?

Dan
When using the attached mask, it crashes with the above error message unless I change the code as I did.

Cu Selur
But the 1-bit mask is an image, while you are getting error on the clip.
Please provide a complete sample with: clip + mask + script

Dan
Doh, you are right.
Here's a link to the source: https://www.mediafire.com/file/nxspwubdh...g.mkv/file
I tested on my side on R74 and it is working.
Please try to test on R74 to see if it works also on your side. 

If, as I suspect, is a problem introduced in R76. 
You should open an issue to myrsloik on Vapoursynth.

Dan
Will do some testing tomorrow, got my gpu busy till tomorrow. Tongue
I tested it with the last dev version  with R77 released today, and it works with no issues.
Given that you are using 1-bit mask you should use: mask_enhance=True, but in any case it works also with  mask_enhance=False.

I noted that in the R77 bundle there is the folder vsdeoldify with about 4GB of models that can be removed, because is not used any more.

Dan

P.S.
to read the source I used: core.lsmas.LWLibavSource()
Quote: I noted that in the R77 bundle there is the folder vsdeoldify with about 4GB of models that can be removed, because is not used any more.
Can you be more specific which pth files are no longer needed?
---
using R77, it works.


Cu Selur
as you know vsdeoldify has been substituted by vshavc and in your bundle all the models (about 4 GB) are correctly located in the vshavc folder.
But I noted that in your bundle there is also the folder vsdeoldify with about 4 GB of models and no *.py. 
I don't know the reason, but this folder can be safely deleted (unless you are using links that are substituted by physical files when put in the archive). 
Please check.

Dan
Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18