+- Selur's Little Message Board (https://forum.selur.net)
+-- Forum: Talk, Talk, Talk (https://forum.selur.net/forum-5.html)
+--- Forum: Small Talk (https://forum.selur.net/forum-7.html)
+--- Thread: Deoldify Vapoursynth filter (/thread-3595.html)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
RE: Deoldify Vapoursynth filter - Selur - 07.09.2025
So when:
- '+Custom' is used: Exemplar Models would need to be enabled. (and can't be disabled)
- '+Restore' is used: Exemplar Models would need to be enabled and forced to specific settings. (and can't be disabled)
And 'light/medium/strong+Restore' does not make any sense to me. (since it should be a preset for 'exemplar models')
Cu Selur
Ps.: send you a link to a test version via pm (which adds support for BlackWhiteMode, but does not change BlackWhiteTune)
RE: Deoldify Vapoursynth filter - Dan64 - 07.09.2025
In the test sample provided there are the 6 cases that Hybrid should be able to manage.
The proposed changes were the ones with minor changes both on your side and my side.
I will think about another way to manage these 6 cases.
The new GUI is Ok, the B&M mode "CLAHE + Simple(luma)" should be changed in "ScaleAbs + Simple(RGB)", I changed this in RC2.
Thanks,
Dan
RE: Deoldify Vapoursynth filter - Selur - 07.09.2025
Quote:the B&M mode "CLAHE + Simple(luma)" should be changed in "ScaleAbs + Simple(RGB)", I changed this in RC2.I adjusted it, but you should rephrase:
:param BlackWhiteMode: Method used by BlackWhiteTune to perform colors adjustments.
Allowed values are:
0 : Apply Contrast Limited Adaptive Histogram Equalization on Luma
1 : Apply Simple Histogram Equalization on all RGB channels
2 : Apply CLAHE on all RGB channels
3 : method=0 and method=1 are merged (default)
4 : Automatic brightness and contrast optimization with ScaleAbs
5 : Auto brigh and contrast optim. with saturation arithmeticCu Selur
Ps.: updated Hybrid_havc_test
RE: Deoldify Vapoursynth filter - Dan64 - 07.09.2025
In the previous link is still available the old version 2025.09.07.1.
I still have to complete the update of comments, only the comment for the function rgb_equalizer was updated (thanks for having reported this issue).
Dan
In the current dev version is provided the parameter "BlackWhitemode" instead of "BlackWhiteMode".
I got the following error
Failed to evaluate the script:
Python exception: HAVC_main() got an unexpected keyword argument 'BlackWhitemode'Dan
RE: Deoldify Vapoursynth filter - Selur - 07.09.2025
Fixed "BlackWhitemode" to "BlackWhiteMode".
updated Hybrid_havc_test (version info is the same)
Cu Selur
RE: Deoldify Vapoursynth filter - Dan64 - 07.09.2025
The new dev version is working.
Thanks,
Dan
RE: Deoldify Vapoursynth filter - Selur - 07.09.2025
Okay, then I can upload a new torch and public dev tomorrow or whenever you fixed the docs&co and made a new release.
Cu Selur
RE: Deoldify Vapoursynth filter - Dan64 - 08.09.2025
Hello Selur,
I have a problem with attached sample.
In the sample there are 2 scripts.
The main code of the script sample3_restore1a.vpy is
clip = core.resize.Bicubic(clip=clip, format=vs.RGB24, matrix_in_s="709", range_in_s="full", range_s="limited")
clip = havc.HAVC_bw_tune(clip, 'medium', 3)
clip = core.resize.Bicubic(clip=clip, format=vs.RGB24, matrix_in_s="709", range_in_s="limited", range_s="full")this script will produce a "flash" at frame 33
The second script sample3_restore1b.vpy not using the conversion from "full" to "limited" is Ok, the main code is simply
clip = havc.HAVC_bw_tune(clip, 'medium', 3)I got the same problem if I use std.Levels in this way
clip = core.std.Levels(clip=clip, min_in=0, max_in=255, min_out=16, max_out=235)
clip = havc.HAVC_bw_tune(clip, 'medium', 3)
clip = core.std.Levels(clip=clip, min_in=16, max_in=235, min_out=0, max_out=255)What do you think, it is a Vapoursynth problem ?
Dan
RE: Deoldify Vapoursynth filter - Selur - 08.09.2025
Hmm,...
clip = core.resize.Bicubic(clip=clip, format=vs.RGB24, matrix_in_s="709", range_in_s="full", range_s="limited")
...
clip = core.resize.Bicubic(clip=clip, format=vs.RGB24, matrix_in_s="709", range_in_s="limited", range_s="full")clip = core.std.Levels(clip=clip, min_in=0, max_in=255, min_out=16, max_out=235)
...
clip = core.std.Levels(clip=clip, min_in=16, max_in=235, min_out=0, max_out=255)Quote: What do you think, it is a Vapoursynth problem ?I doubt it.
RE: Deoldify Vapoursynth filter - Dan64 - 08.09.2025
I will remove the double conversion, it is not strictly necessary.
Dan