![]() |
Improving CodeFormer videos - Printable Version +- Selur's Little Message Board (https://forum.selur.net) +-- Forum: Hybrid - Support (https://forum.selur.net/forum-1.html) +--- Forum: Problems & Questions (https://forum.selur.net/forum-3.html) +--- Thread: Improving CodeFormer videos (/thread-3574.html) |
RE: Improving CodeFormer videos - Dan64 - 07.02.2024 I read your document, but it is not clear how a filter can be added more times. When I check the box "Use Filter Queue" the display change and shows the filters in use. On the right there the symbol "-" to delete a row, but it is missing "+" to add a row, how I can add the same filter more times ? RE: Improving CodeFormer videos - Selur - 07.02.2024 After switching to 'Filter Queue' go to the filter and you will see a '+' and a '-' which allows you to add/remove a filter with a specific setting from the filter queue. If you go do the filter queue you can also change the order of filters. RE: Improving CodeFormer videos - Dan64 - 08.02.2024 Hello Selur, Usually CodeFormer is used with a Resizer. In your example I noted that you used SwinIR, which is a fast and good resizer, but RealESRGAN is better. In Hybrid it is possible to apply the RealESRGAN resizer and the CodeFormer. But CodeFormer allows to use the RealESRGAN resizer directly in the filter. This approach is not supported (are supported only simple resizer like Lanczos). I compared the result obtained using RealESRGAN directly in the filter and the output image is better https://imgsli.com/MjM4NTgx I used the following script # Imports It is possible to add this type of resize in Hybrid ? Thanks Dan P.S. Given the special combination of Resizer and CodeFormer, could be better add this capability in the Resizer page of RealESRGAN, because after CodeFormer the video is upscaled RE: Improving CodeFormer videos - Selur - 08.02.2024 Yes, Hybrid could be extended to support additional resizers for the background upscaling. Main problem is how to properly integrate this in the gui, since there are tons of resizers with tons of options. Cu Selur Ps.: just noticed the 'NNEDI3' as Upscaler is selectable, but I never implemented support for it. :/ RE: Improving CodeFormer videos - Dan64 - 08.02.2024 Hello Selur, I will left CodeFormer as is (eventually you can remove NNEDI3 since is available also in the Resizer Page). My suggestion is to extend the Resizer Page by adding a check box similar to "Stepped Resizer" called something like "CodeFormer Resizer" Where it will be possible to select the CodeFormer options: "Scale", "Weight", "Streams", "Only center" (the "dlib" detector is so slow that is not usable). In this way you can reuse the code already in place for the Resizer. The only difference is that the upscale selected in CodeFormer will force the Resizer output because they must match. Thanks, Dan RE: Improving CodeFormer videos - Selur - 08.02.2024 Not a chance. I will not add additional suff there. Beeing able to combine Stepped Resize and Weighting is already a pain to code and debug. If I add additional Resizers to CodeFormer I will probably add a few option without any additional configuration. RE: Improving CodeFormer videos - Selur - 08.02.2024 Send you a link to a dev version for testing. Cu Selur RE: Improving CodeFormer videos - Dan64 - 09.02.2024 Hello Selur, I tested "RIFE(general)" and is working as expected (good implementation). I was unable to have "RIFE(trt)" working. If I perform the resize using RealESRGAN with TRT enabled, the script is working, while the CodeFormer generated version not. I attached an archive with the 2 scripts generated and the log:
I was unable to find a significant difference, maybe I'm too tired... Thanks, Dan RE: Improving CodeFormer videos - Selur - 09.02.2024 DOH, typo + missing argument. RIFE should be ESRGAN ![]() -> will fix RE: Improving CodeFormer videos - Selur - 09.02.2024 Send you a new link. |