+- Selur's Little Message Board (https://forum.selur.net)
+-- Forum: Talk, Talk, Talk (https://forum.selur.net/forum-5.html)
+--- Forum: Small Talk (https://forum.selur.net/forum-7.html)
+--- Thread: Deoldify Vapoursynth filter (/thread-3595.html)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
RE: Deoldify Vapoursynth filter - Dan64 - 23.03.2024
In order to fix the problems related to AverageFrame.
I'm planning to:
1) limit to 11 frames the max number of frames to be used in the average
2) enable only "central" average because left/right are complementary
3) introduce a weighted average where the near frames have an higher weight.
Here an example with 11 frames
https://imgsli.com/MjQ5Mzc3
This should almost fix the observed problems.
Dan
RE: Deoldify Vapoursynth filter - Selur - 23.03.2024
In your comparisions it would help, if you also added an image with the none weighted result, so see whether it even is a good idea to weight the results.
Quote:enable only "central" average because left/right are complementaryOkay, so 'colstab_mode' will be removed? (I'll at least remove it from the gui, since there's nothing to choose.
)Cu Selur
Ps.: Will adjust Hybrid when a new vs-deoldify version is available.
RE: Deoldify Vapoursynth filter - Dan64 - 23.03.2024
No mode will be still available, with range['arithmetic', 'weighted'] (default = ' weighted ')
Dan
RE: Deoldify Vapoursynth filter - Selur - 23.03.2024
Ah, okay.
Will adjust Hybrid when the time comes.
Cu Selur
RE: Deoldify Vapoursynth filter - Dan64 - 23.03.2024
I'm going to release the attached version.
Respect to the previous version I applied the following changes:
1) "Mode" in "Chroma Stabilization" will accept only values:"arithmetic" (default), "weighted"
2) the max frames allowed in "Chroma Stabilization" now is 15
3) is not more necessary the plugin: "MiscFilters.dll" (will be used the standard Vapoursynth plugin)
4) changed some default value (see the ddeoldify() function header)
5) added new post-process filter "Chroma Limiter"
The new filter "Chroma Limiter" will force the chroma chenges in a frame to be below the chroma deviation limit (default 2%) of previous frame.
The behavior of this new filter is quite satisfactory, see the comparison: https://imgsli.com/MjQ5NTIw
Moreover in the vsdeoldify package I exported 2 new filters extracted from ddeoldify():
#1 Chroma resize filter, derived from ddeoldify
dd_chroma_resize(clip_hires: vs.VideoNode, clip_lowres: vs.VideoNode) -> vs.VideoNode:
and
#2 Video color stabilization filter, derived from ddeoldify
dd_video_stabilizer(clip: vs.VideoNode, chroma_resize: list = [False, 32], color_smoothing: list = [False, 0.1, 0.2, 0.5, 0.8], color_stabilizer: list = [False, 5, 'arithmetic', 1, True], color_limiter: list = [False, 0.02]) -> vs.VideoNode:
The first filter allows to transfer the chroma components from a low resolution movie to the same high resolution movie (useful to speed up filters working on the chroma components).
The second filter is including all the post-process filters developed for ddeoldify() and could be useful to restore movies colored with others applications.
It's up to you to decide if it's worth including them in Hybrid .
Dan
RE: Deoldify Vapoursynth filter - Dan64 - 23.03.2024
I released the new version: https://github.com/dan64/vs-deoldify/releases/tag/v2.0.1
For for compatibility with the previous version, the mode "center" is mapped to "arithmetic" and "left"/"right" to "weighted".
So that this update can also work with the current Hybrid version.
Dan
RE: Deoldify Vapoursynth filter - Selur - 23.03.2024
I'll release a new Hybrid version tomorrow.
(to drunk today - 'Steak Day' with a friend today)
Cu Selur
RE: Deoldify Vapoursynth filter - Dan64 - 24.03.2024
Hello Selur,
sorry to bother you but I have a problem with Vapoursynth that I can't understand.
In order to improve the "chroma limiter", I was thinking to add the possibility to repeat the filter more times (max 5).
To do that I wrote this piece of code
def _clip_chroma_limiter_ex(clip: vs.VideoNode = None, deviation: float = 0.05, steps: int = 1, tht: int = 10) -> vs.VideoNode:
max_steps = max(min(steps, 5), 1)
clip_limited = vs_clip_chroma_stabilizer(clip, deviation=deviation)
for i in range(1, max_steps):
clip_limited=vs_clip_chroma_stabilizer(clip_limited, deviation=deviation)
if tht < 1 or tht > 255:
return clip_limited
# calculate motion mask
clipMask = clip
clipMask = clipMask.resize.Bicubic(format=vs.GRAY8, matrix_s="470bg", range_s="limited")
clipMask = vs.core.motionmask.MotionMask(clip=clipMask, th1=tht, th2=tht, tht=tht) # pixels with abs(diff) < tht will be black (static parts)
clipMask = vs.core.std.InvertMask(clip=clipMask) # invert so that static parts are white (weight=1)
# merge in YUV color space
clipMask = clipMask.resize.Bicubic(format=vs.YUV444PS, matrix_s="470bg", range_s="limited")
clip_limited = clip_limited.resize.Bicubic(format=vs.YUV444PS, matrix_s="470bg", range_s="limited")
clip = clip.resize.Bicubic(format=vs.YUV444PS, matrix_s="470bg", range_s="limited")
clip = vs.core.std.MaskedMerge(clipa=clip, clipb=clip_limited, mask=clipMask) # MotionMask
# restore RBG24 color space
clip = clip.resize.Bicubic(format=vs.RGB24, matrix_in_s="709", range_s="limited", dither_type="error_diffusion")
return clipNow the problem:
If I set "tht=0" the motion mask is not applied and I can see the filter working:
Here with steps=1
Here with steps=5
But if I set "tht" with a value > 1 and < 255, independently from the value I get always the same image:
like the Mask was always filled with weights=0
Do you have any idea on the reason ?
Dan
RE: Deoldify Vapoursynth filter - Selur - 24.03.2024
Side note, looking at:
clip_limited = vs_clip_chroma_stabilizer(clip, deviation=deviation)
for i in range(1, max_steps):
clip_limited=vs_clip_chroma_stabilizer(clip_limited, deviation=deviation)Otherwise for max_steps the filter would be applied 'max_steps +1 '-times.
Quote:Now the problem:Okay, what is the problem, atm.
If I set "tht=0" the motion mask is not applied and I can see the filter working:
Here with steps=1
if tht < 1 or tht > 255:
return clip_limitedShouldn't "if tht < 1 or tht > 255" be "if tht < 9 or tht > 255" ?
Cu Selur
RE: Deoldify Vapoursynth filter - Selur - 24.03.2024
Ah, post wasn't finished. (Images were just shown without explaination as attachment)