Selur's Little Message Board
Deoldify Vapoursynth filter - Printable Version

+- Selur's Little Message Board (https://forum.selur.net)
+-- Forum: Talk, Talk, Talk (https://forum.selur.net/forum-5.html)
+--- Forum: Small Talk (https://forum.selur.net/forum-7.html)
+--- Thread: Deoldify Vapoursynth filter (/thread-3595.html)



RE: Deoldify Vapoursynth filter - Selur - 30.03.2024

Ah, found the mistake.
=> updated download

Cu Selur


RE: Deoldify Vapoursynth filter - Dan64 - 30.03.2024

Here the new RC5 with the corrected descriptions.

Dan


RE: Deoldify Vapoursynth filter - Selur - 30.03.2024

Nice, last download should still work.

Cu Selur


RE: Deoldify Vapoursynth filter - Dan64 - 30.03.2024

I found the following issues:

1) The “auto” parameter for render_factor in ddcolor is not managed
2) It is not managed the “render_factor” in  ddeoldify_stabilizer you can set it = max(ddcolor_rf, deoldify_rf)
3) most of the descriptions need to be updated with the last RC5

In the last RC5, the default for "stab" is False and not more True, and need to be managed

Thanks,
Dan



T


RE: Deoldify Vapoursynth filter - Selur - 30.03.2024

updated the download (had no time to test)

Cu Selur


RE: Deoldify Vapoursynth filter - Dan64 - 30.03.2024

All the issues fixed with the only exception of "auto" setting for ddcolor

When "auto" is checked should be generate the following code

ddcolor_p=[1, 0, 1, 0, True]

instead of is generated the following code

ddcolor_p=[1, 24, 1, 0, True]

Dan


RE: Deoldify Vapoursynth filter - Selur - 30.03.2024

you wrote to use 'max(ddcolor_rf, deoldify_rf)' and sice ddcolor_rf is 0 'ddcolor_p=[1, 0, 1, 0, True]' is used,...
=> this is what you asked for,...


RE: Deoldify Vapoursynth filter - Selur - 30.03.2024

I adjusted the code to set zero if one of the two is zero and use the max of them otherwise.
(updated download)

Cu Selur


RE: Deoldify Vapoursynth filter - Dan64 - 30.03.2024

Ok, it is better to remove the "auto" option in the GUI. 
The users should be able to know what value to use, if not the default value is good enough.

Thanks,
Dan


RE: Deoldify Vapoursynth filter - Selur - 30.03.2024

How is render_factor calculated when auto is enabled?
(not at home atm.)
If Hybrid has the values too, I could adjust Hybri accordingly to set render_factor to that value when 'auto' is enabled.

Cu Selur