+- Selur's Little Message Board (https://forum.selur.net)
+-- Forum: Talk, Talk, Talk (https://forum.selur.net/forum-5.html)
+--- Forum: Small Talk (https://forum.selur.net/forum-7.html)
+--- Thread: Deoldify Vapoursynth filter (/thread-3595.html)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
RE: Deoldify Vapoursynth filter - Dan64 - 01.05.2024
To test the new version I enabled Vapoursynth->Misc->Don't hide defaults
I found the following issues:
1)
Preset="fast"
ColorFix="Violet/Red"
ColorMap="none"
ColorTune="light"
is generated the following code
clip = ddeoldify_main(clip=clip, Preset="fast", ColorFix="violet/red", ColorMap="none", ColorMap="light", enable_fp16=True)Where ColorMap is passed 2 times and is missing ColorTune
2)
Preset="slow"
ColorMap="blue->brown"
ColorFix="Violet/Red"
ColorTune="Light"
clip = ddeoldify_main(clip=clip, Preset="slow", ColorFix="violet/red", ColorMap="blue->brown", ColorMap="light", enable_fp16=True)
is generated the following code
clip = ddeoldify_main(clip=clip, Preset="slow", ColorFix="violet/red", ColorMap="blue->brown", ColorMap="light", enable_fp16=True)Same issue of previous test
3)
Preset="custom"
ColorMap is disabled
ColorTune is disabled
ColorTune not disabled (should be disabled as well)
I don't have found other issues.
Dan
RE: Deoldify Vapoursynth filter - Selur - 01.05.2024
Quote:Preset="custom"What? ah the second one was ment to be ColorFix.
ColorMap is disabled
ColorTune is disabled
ColorTune not disabled (should be disable as well)
=> updated test download
Cu Selur
RE: Deoldify Vapoursynth filter - Dan64 - 01.05.2024
Every time I run Hybrid, is displayed the following message
Dan
RE: Deoldify Vapoursynth filter - Selur - 01.05.2024
ah, typo 'vsDeoldifyColorTune' should be 'vsDeOldifyColorTune'.
Updated the download, should be fixed now.
Cu Selur
RE: Deoldify Vapoursynth filter - Dan64 - 01.05.2024
I found another issue: in "custom" mode, ColorMap is not provided in input to ddeoldify_stabilizer()
RE: Deoldify Vapoursynth filter - Selur - 01.05.2024
Will look at it tomorrow after work
RE: Deoldify Vapoursynth filter - Selur - 02.05.2024
had a quick look at it before work, updated the download
RE: Deoldify Vapoursynth filter - Selur - 02.05.2024
Won't probably release a new Hybrid version any time soon, since vsViewer has a memory leak.
If you refresh it a few times memory increases,... no clue how to fix that atm.
=> so unless I can figure that out over the weekend, I might not release a new Hybrid version this month, since I then probably will have to look into adjusting another viewer as basis for the preview in Hybrid.
RE: Deoldify Vapoursynth filter - Dan64 - 02.05.2024
It is strange that this memory leak on vsViewer was discovered only now. Did you changed something recently ?
I will look to my modded version to see if there is a memory leak (it is the only version that I can debug).
Dan
RE: Deoldify Vapoursynth filter - Selur - 02.05.2024
No, haven't changed much in vsViewer for ages.
What happens is that if your open a script and refresh the preview with F5 memory consumption will increase, the 'heavier' the script the more ram will be consumed.
Unless I find the time to seriously spend time on that it, I will probably will switch from
https://bitbucket.org/mystery_keeper/vapoursynth-editor
as a basis to something else.
(and then probably spend the next few month on that)
maybe I'll clone https://github.com/Jaded-Encoding-Thaumaturgy/vs-preview and start learning some more Python.
Cu selur