+- Selur's Little Message Board (https://forum.selur.net)
+-- Forum: Talk, Talk, Talk (https://forum.selur.net/forum-5.html)
+--- Forum: Small Talk (https://forum.selur.net/forum-7.html)
+--- Thread: ProPainter Vapoursynth filter (/thread-3720.html)
RE: ProPainter Vapoursynth filter - Dan64 - 30.05.2024
This is the log of Hybrid
Quote:-> skipped 'Intel® UHD Graphics 630' since it's no NVIDIA card
Detected NVIDIA PureVideo compatible cards: NVIDIA GeForce RTX 3060
Detected vfwDecoders with 32bit: VIDC.FFDS VIDC.LAGS VIDC.X264 VIDC.XVID vidc.cvid vidc.i420 vidc.iyuv vidc.mrle vidc.msvc vidc.uyvy vidc.yuy2 vidc.yvu9 vidc.yvyu
Detected vfw64BitDecoders: VIDC.LAGS VIDC.X264 VIDC.XVID vidc.i420 vidc.iyuv vidc.mrle vidc.msvc vidc.pDAD vidc.uyvy vidc.yuy2 vidc.yvu9 vidc.yvyu
Avisynth+ is available,..
DGDecNV available,..
Vapoursynth is available,..
DGDecNV available,..
VSGAN available,..
vsDPIR available,..
vsRIFE (torch) available,..
vsSwinIR available,..
vsHINet available,..
vsSCUNet available,..
vsCodeFormer available,..
vsGRLIR available,..
vsDDColor available,..
vsDeOldify available,..
vsProPainter available,..
VSMLRT available,..
vsRIFE (mlrt) available,..
vsDPIR (mlrt) available,..
vsSAFA (mlrt) available,..
changing WindowStyle from 'windowsvista' to 'Fusion
changing WindowStyle from 'fusion' to 'Fusion
Current defaultOutputPath: is empty!
-> Set it under Config->Path
Current defaultTempPath: is empty!
-> Set it under Config->Path
vsProPainter is listed as available, but no code using it is generated when is selected as filter in Filtering->Vapoursynth->Other
Dan
As you can see I selected ProPainter
But is not generated any code when I create the encoding job.
I attached the full log.
Dan
In this screenshot is shown the script generated when I check ProPainter.
ProPainter is not included in the generated script.
Dan
RE: ProPainter Vapoursynth filter - Selur - 31.05.2024
You entered no Mask. => nothing to do.
ProPainter:
a. needs to be in the FilterOrder (Filtering->Vapoursynth->Misc->Filter Order/Queue)
b. it need to be enabled (Filtering->Vapoursynth->Other->ProPainter)
c. a Mask need to be set (Filtering->Vapoursynth->Other->ProPainter->Mask)
Since the Mask is essential and there is no default Mask or anything like that (same with for example, Other->AddLogog, Other->GLSL, Other->VSGAN) adding a not usable entry to the Script does not make sense.
Cu Selur
RE: ProPainter Vapoursynth filter - Selur - 31.05.2024
Updated the test download.
Hybrid now adds '# Not using ProPainter, since no Mask is set' to the script, if Mask isn't set.
Cu Selur
Ps.: To get a better feel for ProPainter (what it can do, what screws to turn and where are the limitations) I opened a thread over at videohelp hoping some folks will share some short clips with watermarks&co to remove.
RE: ProPainter Vapoursynth filter - Dan64 - 31.05.2024
Ok, now is working, yesterday I was too tired to do a decent test...
To me the implementation in Hybrid it's Ok.
I like the debug option for the mask region.
You should add an option to select a mask image or a mask clip.
In the case is selected a mask image is not more necessary to convert the image to clip, since RC4 the "mask region" is supported also on the single images.
On my PC using the single image instead of a video clip is a little faster: from 1.93fps to 1.99fps.
So there is not reason to add the conversion in clip mask.
Instead it is missing the possibility to add a mask clip. You should add it.
I added a couple of samples to use to test the clip mask.
I also attached the RC5 version. I performed only small changes: I updated the description of parameters because previously some of them were wrong.
If are not found bugs, this week-end I will release the version 1.0 in github.
Thanks,
Dan
RE: ProPainter Vapoursynth filter - Selur - 31.05.2024
Will do some testing and report back.
RE: ProPainter Vapoursynth filter - Selur - 31.05.2024
Uploaded a new test version, which allows to either use an image or a video as mask. (also the image is now directly fed to ProPainter)
Quote:I updated the description of parameters because previously some of them were wrongmight have missed some,...
Quote:If are not found bugs, this week-end I will release the version 1.0 in github.Do that. (you could also release DeOldify 4.0.0)
Cu Selur
RE: ProPainter Vapoursynth filter - zspeciman - 31.05.2024
That is an interesting project, lets see what can be done with this clip
RE: ProPainter Vapoursynth filter - Dan64 - 31.05.2024
(31.05.2024, 19:17)Selur Wrote:Quote:I updated the description of parameters because previously some of them were wrongmight have missed some,...
main typos was on the description raft_iter
old:
Quote::param raft_iter: Iterations for RAFT inference. Low values will decrease the inferencenew:
speed but could affect the output quality. Default: 20
Quote::param raft_iter: Iterations for RAFT inference. Low values will increase the inference
speed but could affect the output quality. Default: 20
Dan
(31.05.2024, 19:17)Selur Wrote: Uploaded a new test version, which allows to either use an image or a video as mask. (also the image is now directly fed to ProPainter)
The new version is Ok.
Comparing the torch package R65 with R68 I found the following (main) packages missing:
dlib 19.24.1
dlib-bin 19.24.2
kornia 0.7.0
onnxruntime-gpu 1.17.1
safetensors 0.3.1
scikit-image 0.22.0
scipy 1.12.0
setuptools 67.7.2
vsgan 1.6.4
vsgmfss_fortuna 1.0.0
vsrealesrgan 4.1.0are you planning to add them ?
Dan
RE: ProPainter Vapoursynth filter - Selur - 01.06.2024
vsgan is in both, you probably mean vsfemasr.
Like mentioned here and over at https://github.com/HolyWu/vs-dpir/issues/41:
- vsanimesr
- vsfemasr
- vsrealesrgan
- vsgmfss-fortuna
- vsbasicvsrpp
Sadly, I have no clue how to modify the projects themselves to be Python 3.12 compatible. HolyWu probably could modify the first four, but for example vsbasicvsrpp relies on openmim which from the looks of it does not work with anything newer than Python 3.11 atm.
=>
Do I want to add those filters: Yes
Will it happen in the near future: Unlikely
Do I think I can actively do something about it: I do not think so.
Cu Selur
RE: ProPainter Vapoursynth filter - Dan64 - 01.06.2024
Since python 3.12 is braking the compatibility of some filters (you don't have included dblib which is used by code former), why you don't continue to use python 3.11 ?
Dan