Selur's Little Message Board
Deoldify Vapoursynth filter - Printable Version

+- Selur's Little Message Board (https://forum.selur.net)
+-- Forum: Talk, Talk, Talk (https://forum.selur.net/forum-5.html)
+--- Forum: Small Talk (https://forum.selur.net/forum-7.html)
+--- Thread: Deoldify Vapoursynth filter (/thread-3595.html)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81

RE: Deoldify Vapoursynth filter - Dan64 - 10.06.2024

Released in github the version 4.0.0: https://github.com/dan64/vs-deoldify/releases/tag/v4.0.0
I updated also the README

Respect to the RC4 version I added a control in the case DeepEx is enabled with method: 0,1,2 but the reference frames are not generated.
If these conditions are verified is raised an error.

Dan

RE: Deoldify Vapoursynth filter - Selur - 10.06.2024

Any reason why 4.0.0 requires vapoursynth>=65 ? (old R65 version only reports as R62, since there was no proper wheel file Wink)

Cu Selur

RE: Deoldify Vapoursynth filter - Dan64 - 10.06.2024

My testing environment is using R65 (current version used by Hybrid) and R68 (future version that will be used by Hybrid). 
Since this filter should be used with Hybrid I aligned the requirement to Hybrid.

Dan

RE: Deoldify Vapoursynth filter - Selur - 10.06.2024

How did you install 4.0.0 with the R65 package, for me that does not work.

RE: Deoldify Vapoursynth filter - Dan64 - 10.06.2024

It seems that there is a problem with the dependency from R65. 
I lowered the requirement and updated the wheel in github. 
This version works.

RE: Deoldify Vapoursynth filter - Selur - 10.06.2024

Thanks. Smile

RE: Deoldify Vapoursynth filter - Dan64 - 10.06.2024

(10.06.2024, 16:48)Selur Wrote: @Dan64: Adjusted Hybrid to set sc_thresholds minimum to 0 when DeepEx is enabled and 0 otherwise. Through this, sc_threshold will be at least 0.01 when DeepEx is enabled.
Not checking for images when '... external ...' is used, since to do it seriously one would have to check that all images:
  • exist
  • are really pngs
  • their image resolution is correct  (= matches the resolution at the place DeOldify is used)
  • their naming scene is correct and the frame count fits into the current clip
=> Not doing that, since I think folks that use '... external ...' should know what they are doing. Smile
(updated the deolidfy test download)

Cu Selur

In the released version 4.0 I added also a control on the directory and is raised an error when the directory is specified but not valid images are found.
As stated previously I added a control also on sc_threshold so you can remove you setting to 0.01 and let the user to set the appropriate value.

If you want to keep it you should set to 0.10 when DeepEx is selected and sc_threshold =0 and sc_min_freq=0, but please allow the possibility to set it to 0 (currently cannot be below 0.01) because the reference frames can be set also using sc_min_freq.

Actually if DeepEx is deselected there is no reason to pass the parameters sc_threshold and sc_min_freq to HAVC_ddeoldify(), so these values can be left untouched because don't have to be passed to HAVC_ddeoldify().

I found a bug in the following setting

[Image: attachment.php?aid=2550]

In this case is generated the following code

# adding colors using DeOldify
from vsdeoldify import HAVC_ddeoldify
clipRef = HAVC_ddeoldify(clip=clip, deoldify_p=[0, 24, 1, 0], ddcolor_p=[1, 24, 1, 0, True], ddtweak=True, ddtweak_p=[0.0, 1.0, 2.5, True, 0.3, 0.6, 0.7, 0.5, "300:360|0.4,0.1"], sc_threshold=0.01)
from vsdeoldify import HAVC_deepex
clip = HAVC_deepex(clip=clip, clip_ref=clipRef, ref_merge=0, dark="True", smooth=True, sc_framedir="D:/PProjects/vs-deoldify_dev/TestPreset/Test10")

for some reason is filled the parameter "sc_framedir" even if in the GUI the directory box is empty.

Dan

RE: Deoldify Vapoursynth filter - Selur - 10.06.2024

Quote:for some reason is filled the parameter "sc_framedir" even if in the GUI the directory box is empty.
Hybrid does set the default temp folder if sc_framedir/ScFrameDir is empty.

I:
  • removed the 0.01 minimum adjustment for sc_threshold
  • only add sc_threshold, sc_min_freq when DeepEx is used (sc_threshold is now disabled unless DeepEx is enabled, and sc_min_freq is disabled unless DeepEx is used and DeepExMethod == 0
  • ScFrameDir and sc_framedir will not be set if they are empty.
(updated deoldify test download)

Cu Selur

RE: Deoldify Vapoursynth filter - Selur - 10.06.2024

Since vsrealesrgan 5.0.0 is released and R68 compatible, I'll drop the R65 torch-addon.
(never got feedbackt regarding vsanimesr and vsgmfss-fortuna, so it's no problem that they are still R68 incompatible)

Cu Selur

RE: Deoldify Vapoursynth filter - Dan64 - 10.06.2024

Good news! Smile 

Dan