Selur's Little Message Board
Deoldify Vapoursynth filter - Printable Version

+- Selur's Little Message Board (https://forum.selur.net)
+-- Forum: Talk, Talk, Talk (https://forum.selur.net/forum-5.html)
+--- Forum: Small Talk (https://forum.selur.net/forum-7.html)
+--- Thread: Deoldify Vapoursynth filter (/thread-3595.html)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81

RE: Deoldify Vapoursynth filter - Selur - 15.12.2024

I did not update the dev version, only the test .exe only upload.
[Image: grafik.png]

Cu Selur

RE: Deoldify Vapoursynth filter - Selur - 16.12.2024

Did you test the test (Hybrid_deoldify) version?

RE: Deoldify Vapoursynth filter - Dan64 - 16.12.2024

Yes it works as expected. Smile

But in my dev version 2024.12.15.1 the RealESRGAN resizer is not working.

The generated script is the following

clip = RealESRGAN(clip=clip, model=5, device_index=0, trt=True, trt_cache_dir=r"D:\PProjects\vs-deoldify_dev\clips", trt_workspace_size=1073741824, trt_int8=False, denoise_strength=0.50, num_streams=1) # 2960x2160


And I get the following error:

2024-12-16 14:16:20.625
Failed to evaluate the script:
Python exception: realesrgan() got an unexpected keyword argument 'trt_int8'

Could you check ?

Dan

RE: Deoldify Vapoursynth filter - Selur - 16.12.2024

Will check.

RE: Deoldify Vapoursynth filter - Selur - 16.12.2024

I missed that the option was removed in:
https://github.com/HolyWu/vs-realesrgan/commit/e625549e5144f4c54e94168d5dc7c7cdb2bc62f6#diff-43acb6bd3d1374bf5af07ec871312d46cca1d14121e2af759adba059236331c5L91
=> will fix

Cu Selur

RE: Deoldify Vapoursynth filter - Selur - 16.12.2024

=> Uploading a new dev&torch package, will be up in ~1hour.

Cu Selur

RE: Deoldify Vapoursynth filter - Dan64 - 16.12.2024

Installed new torch packages and dev version and not it seems OK.

You should add in Hybrid the support for vs-realesrgan new parameter: num_batches.

As stated in the release of v5.1.0: Improve performance by using separate streams and non_blocking for moving tensors between CPU and GPU. Now num_streams arg has negligible influence on performance compared to num_batches arg.

So by enabling num_batches the performance of vs-realesrgan should improve significantly.

Dan

RE: Deoldify Vapoursynth filter - Selur - 16.12.2024

Quote:Installed new torch packages and dev version and not it seems OK.
not -> now ?
Is it okay or not?

Quote:You should add in Hybrid the support for vs-realesrgan new parameter: num_batches.
will add later, first wanted to be sure the other stuff is okay.

Cu Selur

RE: Deoldify Vapoursynth filter - Dan64 - 16.12.2024

(16.12.2024, 19:17)Selur Wrote:
Quote:Installed new torch packages and dev version and not it seems OK.
not -> now ?
Is it okay or not?

It's OK, but I haven't had time to test it extensively yet.

Dan

RE: Deoldify Vapoursynth filter - Selur - 16.12.2024

Ok, uploaded a new dev which adds num_batches support to RealESRGAN.

Cu Selur