Selur's Little Message Board
Deoldify Vapoursynth filter - Printable Version

+- Selur's Little Message Board (https://forum.selur.net)
+-- Forum: Talk, Talk, Talk (https://forum.selur.net/forum-5.html)
+--- Forum: Small Talk (https://forum.selur.net/forum-7.html)
+--- Thread: Deoldify Vapoursynth filter (/thread-3595.html)



RE: Deoldify Vapoursynth filter - Dan64 - 10.01.2025

Wow! you changed a lot the GUI. It's very nice and much better than the previous version.

I found few bugs. 

The custom parameters are properly applied with the only exception of Combine Method that is not switching to "DDColor only" when necessary (see pictures)


[Image: attachment.php?aid=2880]

[Image: attachment.php?aid=2881]

Then the parameter ColorModel is propagated properly in the custom section, but is not added to HAVC_main function call (see picture)

[Image: attachment.php?aid=2882]

Thanks for the GUI upgrade, I like it a lot  Smile
Dan

Found another bug when is selected the "custom" preset (see picture)

[Image: attachment.php?aid=2883]


RE: Deoldify Vapoursynth filter - Selur - 10.01.2025

Uploaded an updated Hybrid_deoldify version for testing.
(haven't looked at the last bug)

Cu Selur


RE: Deoldify Vapoursynth filter - Selur - 10.01.2025

Uploaded an updated Hybrid_deoldify version for testing.

Cu Selur


RE: Deoldify Vapoursynth filter - Dan64 - 10.01.2025

The reported bugs were solved.

But I found another bug: when the Exemplar Models are enabled and is selected a method starting with "HAVC", the dropbox "Ref merge" is enabled. 
The problem is that even if enabled is not possible to select a "Ref merge" different from "no".
I think that is missing the callback.

Please check it.

Dan


RE: Deoldify Vapoursynth filter - Selur - 10.01.2025

Will look at it tomorrow


RE: Deoldify Vapoursynth filter - Selur - 11.01.2025

Uploaded an updated Hybrid_deoldify version for testing.
Let me know whether that version fixes the problem.

Cu Selur


RE: Deoldify Vapoursynth filter - Dan64 - 11.01.2025

The version 2025.01.11.1 has just a small bug regarding the flag "Vivid"
This flag should always enabled when are used the Exemplar Models".

Dan


RE: Deoldify Vapoursynth filter - Selur - 11.01.2025

What is the bug?
It's enabled by default and unless a user disables it, it seems to stay enabled.
If users shouldn't be able to disable it, shouldn't it get removed?
Atm. the logic in Hybrid is that unless 'Method' is set to 'HAVC' 'Vivid' gets disabled. (Hybrid never changes the value of vivid,..)

Cu Selur


RE: Deoldify Vapoursynth filter - Dan64 - 11.01.2025

The logic need to be changed.
Previously the parameter "Vivid" had a small effect, but now with ColorMNet the parameter "Vivid" impact on how is used the frames' memory.
When is enabled "Exemplar Models" the parameter "Vivid" needs to be always enabled. Of course the user can decide to check/uncheck it, but to do that the flag must be enabled at GUI level.

Dan


RE: Deoldify Vapoursynth filter - Selur - 11.01.2025

Uploaded an updated Hybrid_deoldify version for testing.
Hybrid now never 'Vivid' disables or changes the value of 'Vivid'.

Cu Selur