Deoldify Vapoursynth filter

[Selur]

I give up.
Your explanations always tells only half the story and when I ask for clarification, tons of stuff additionally changes.

With every iteration, it becomes more and more complicated to support this.

I'm not adding support for 'Deep-Remaster' or 'ref_freq' or the new interpretation of DeeEx 'method = 5'.
a. I still don't get ref_freq.
b. not adding additional file selection for HAVC_deepex clip_ref and generating additional code for it. Since I'm still unclear when this should be added and where and what are all the side effects that would have to be taken into consideration.

Should I
Keep

4) NEW ColorMNet encode_mode=2 -> "remote all-ref"
5) NEW PRESET: BlackWhiteTune

as the support is atm. or shoud I remove them and go back to the state version v4.6.7 was supported?

Should I drop the HAVC support for the future?
Maybe it was a stupid idea to start this in the beginning, maybe the only reasonable way to support HAVC is to do it in a setting where you write your own gui&co.
Maybe HAVC should not be one but multiple filters in Hybrid.

Cu Selur

Ps.: removed 'Deep-Remaster' from the ex_method again, since I'm unsure whether this makes any sense without the additional changes I'm not doing. Updated Hybrid_deoldify.

[Dan64]

I can understand your point of view.
Every time I apply a change I try to keep at minimum the GUI changes.

As you said the following changes have little impact on the GUI:

NEW ColorMNet encode_mode=2 -> "remote all-ref"
NEW PRESET: BlackWhiteTune

But I think that also DeepRemaster has little impact on the GUI, it is just another item in the ComboBox.

I can understand that the remaining changes are too complex.

If you want you can remove the method 5 from the GUI. 

It will be still available in the code, but the user cannot select it from the GUI.

I think that this is a reasonable compromise.

Thanks,
Dan

[zspeciman]

Please please please continue this project.  The Exemplar Models have been a phenomenal.  Each update has been a step forward in the colorization tool.  If it wasn't for the wonderful and detailed guide, I'd be completely lost.  These parameters applied differently depending on the clips are justified.  Shaq and Kobe had their differences and together won the NBA championship, Steve Jobs and Steve Wozniak, Bill Harley and Arthur Davidson, Lennon and McCartney etc.  All those collaborations despite their ups and downs, have led to marvelous outcomes.  I hope other users will voice their support as well. Thank you both.

[Selur]

I added 'Deep-Remaster' back to the DeepEx model selection and changed the 'core.num_threads = 1' requirement.

Updated Hybrid_deoldify.

If you want you can remove the method 5 from the GUI.

I leave it as it is atm.

Cu Selur

[Dan64]

The implementations of

ColorMNet encode_mode=2 -> "remote all-ref"
PRESET: BlackWhiteTune 

are Okay.

DeepRemaster like ColorMNet is using the parameter max_memory_frames, so it is necessary to add this field in the GUI



Now, regarding the method=5, this is my proposal:

When is selected the method=5: 

1) you skip the call to HAVC_ddeoldify (in custom mode)
2) in HAVC_deepex you pass clip_ref=None  (in custom mode)
3) in the field sc_framedir you pass the clip provided in input as show in the picture below (both in custom/preset mode)



so, only in the case of method=5 you should allow to select a clip instead of a folder in "Ref FrameDir", I will try to manage to read the clip inside the filter as you suggested.

Thanks,
Dan

[Selur]

Uploaded a new Hybrid_deoldify.
Didn't test it. Might work, might not, someone else can test.


If you add any additional option to HAVC again, do not expect me to add it unless:
a. for each added parameter, at least one existing parameter gets removed
b. you properly explain the side effects of that option
otherwise, I will simply drop HAVC from Hybrid.

Cu Selur

[Dan64]

Now  max_memory_frames for DeepRemaster is managed correctly.

But the implementation of method=5 is still incomplete.

the following requirements were not implemented:

1) skip the call to HAVC_ddeoldify (in custom mode)
2) in HAVC_deepex pass clip_ref=None  (in custom mode)

regarding the field sc_framedir :

it is implemented only the possibility to select a clip, it is missing:

1) the clip is not shown in GUI when is selected
2) in the field sc_framedir is not provided the path of selected clip

Dan

[Selur]

Might be fixed now, uploaded new Hybrid_deoldify.

Cu Selur

[Dan64]

I'm tired to continue the testing today.

if it's not a problem for you.
I propose to postpone the testing and development until next week.

Thanks,
Dan

[Selur]

sure