[BUG] LSFmod in VapourSynth sets incorrect values

[Selur]

To start please refer to https://github.com/Selur/VapoursynthScri...avsfunc.py
https://github.com/Selur/VapoursynthScriptsInHybrid contains the scripts that ship with Hybrid.

Also note that Avisynth and Vapoursynth filters often don't act the same way.

According to the above linked Vapoursynth script, Lmode only has positive values of 1-4, with 0 being none.

No.

### Lmode [int: ...,0,1,2,3,4]
### --------------------------
### Limit mode:
###    <0 : Limit with repair (ex: Lmode=-1 --> repair(1), Lmode=-5 --> repair(5)...)
###    =0 : No limit
###    =1 : Limit to over/undershoot
###    =2 : Limit to over/undershoot on edges and no limit on not-edges
###    =3 : Limit to zero on edges and to over/undershoot on not-edges
###    =4 : Limit to over/undershoot on edges and to over/undershoot2 on not-edges

says that negative values are limited by the corresponding repair(X) mode.
Which is why Hybrid, uses:

values.clear();
  values << QString("Repair(18)"); //index 0
  values << QString("Repair(17)");
  values << QString("Repair(16)");
  values << QString("Repair(15)");
  values << QString("Repair(14)");
  values << QString("Repair(13)"); //index 5
  values << QString("Repair(12)");
  values << QString("Repair(11)");
  values << QString("Repair(10)");
  values << QString("Repair(9)");
  values << QString("Repair(8)"); //index 10
  values << QString("Repair(7)");
  values << QString("Repair(6)");
  values << QString("Repair(5)");
  values << QString("Repair(4)");
  values << QString("Repair(3)");  //index 15
  values << QString("Repair(2)");
  values << QString("Repair(1)");
  values << QString("No Limit");
  values << QString("Limit to over/undershoot");
  values << QString("Limit to over/undershoot on edges and no limit on not-edges");
  values << QString("Limit to zero on edges and to over/undershoot on not-edges");
  values << QString("Limit to over/undershoot on edges and to over/undershoot2 on not-edges");
  this->addListField(QString("vsLSFModLmode"), QString("No Limit"), values, true);

That being said you are right, seems like the offset Hybrid uses is wrong atm. it uses -15, where it should use -18.
-> will fix.

It really would have helped if you had looked at the scripts that ship with Hybrid and report Avisynth and Vapoursynth separately.
Reading the rest will take me tons of time, since I will have to compare what is happening with the currently used scripts and first need to do a write up of your stuff to get to the bottom what is not working and what did change in the scripts since the time I implemented support for them.
-> will probably remove support for lsfmod in Avisynth and Vapoursynth until I find time and motivation to look into it.


Cu Selur