Deoldify Vapoursynth filter

[Selur]

Is there a scenario where it makes sense to disable 'chrez', if not, it should be removed from the parameters.

Another question: Does the input resolution influence the result ?
I was wondering whether resizing HD to SD resolution before applying deoldify and ddcolor and later upscale and copy the chroma to the original would make sense to speed things up or whether this would only lower the accuracy / temporal consitency?

otherwise:

# frame size calculation for inference()    
    frame_size = min(render_factor * 16, clip.width)
    
    if chroma_resize_enabled:
        clip_orig = clip;
        clip = clip.resize.Spline64(width=frame_size, height=frame_size)

should be:

if chroma_resize_enabled:
        # frame size calculation for inference()    
        frame_size = min(render_factor * 16, clip.width)
        clip_orig = clip;
        clip = clip.resize.Spline64(width=frame_size, height=frame_size)

additionally:

chrez: bool = True, chrez_p: int = 24)

_p parameters should always be lists.
if you only got one parameter it should have it's own name so chrez_p should be render_factor.

CMC_p: float = 0.2, LMM_p: list = [0.3, 0.6, 1.0]

to keep the naming consistent, CMC and LLM should be lower case.
also since 'CMC_p' is has only one paramater it should be 'cmc_thresh'.
maybe change 'cmb_inv' to 'cmb_sw' for combine_switch switching seems more fitting than inverse.

:param LMM_p:               parameters for method: "Luma Masked Merge"
                                   [0] : luma_mask_limit, luma limit for build the mask used in Luma Masked Merge, range [0-1] (0.01=1%)
                                   [1] : luma_white_limit, if > luma_mask_limit will be applied a gradient till luma_white_limit, range [0-1] (0.01=1%)
                                   [2] : luma_mask_sat: if < 1 the ddcolor dark pixels will substitute with the desaturated deoldify pixels, range [0-1] (0.01=1%)

Can you change the description of luma_mask_limit and luma_white_limit ? atm. they don't really seem to make sense.



Cu Selur