30.03.2024, 09:08
(30.03.2024, 07:57)Selur Wrote: Is there a scenario where it makes sense to disable 'chrez', if not, it should be removed from the parameters.
Another question: Does the input resolution influence the result ?
I was wondering whether resizing HD to SD resolution before applying deoldify and ddcolor and later upscale and copy the chroma to the original would make sense to speed things up or whether this would only lower the accuracy / temporal consitency?
for what concern the chroma filters: "cherez" enabled will not affect the output resolution, so it makes sense to remove from the parameter list and left it always enabled (I introduced the flag mainly for testing).
Unfortunately the input resolution impacts the inference and filters speeds, that's the reason why I introduced the render factor also in the stabilizer.
The downsize before the inference and then the upscale is already implemented by the render_factor, no reason to implement it externally.
Also the resizer used to downscale has little impact (both deoldify and ddcolor are using "bilinear") because the luma restore is able to provide back the full original resolution.
I will apply the proposed changes in the next RC.
Dan
P.S.
The explanation of "Luma Masked Merge" is provided in the "method" description of this filter