01.05.2024, 11:47
Hello Selur,
I changed vsdeoldify to use internally the full range, previously vsdeoldify was using the limited range.
This change together with your change, fixed the problem related to the color space conversion.
You can find the comparison here: https://imgsli.com/MjYwNTM4
Regarding the new version provided by you, a part the conversion of the range from "limited" to "full", I noted that you added the support to ColorTune.
Unfortunately the implementation is not working perfectly. Main issues found are:
1) ColorTune is propagated to the custom parameters, but is not passed to the function ddeoldify_main()
2) In some case ColorTune is not propagated correctly in the custom parameters (its destination is depending from selected preset)
3) ColorMap is not propagated correctly to custom parameters (its destination is depending from selected preset) and affects also ColorFix custom parameters
I attached the new version with the support of "full range"
Dan
P.S.
In this release, in the clip description of function ddeoldify() I added the following advice: please remove any grain from the clip, because it will create artifacts on colored frames.
I changed vsdeoldify to use internally the full range, previously vsdeoldify was using the limited range.
This change together with your change, fixed the problem related to the color space conversion.
You can find the comparison here: https://imgsli.com/MjYwNTM4
Regarding the new version provided by you, a part the conversion of the range from "limited" to "full", I noted that you added the support to ColorTune.
Unfortunately the implementation is not working perfectly. Main issues found are:
1) ColorTune is propagated to the custom parameters, but is not passed to the function ddeoldify_main()
2) In some case ColorTune is not propagated correctly in the custom parameters (its destination is depending from selected preset)
3) ColorMap is not propagated correctly to custom parameters (its destination is depending from selected preset) and affects also ColorFix custom parameters
I attached the new version with the support of "full range"
Dan
P.S.
In this release, in the clip description of function ddeoldify() I added the following advice: please remove any grain from the clip, because it will create artifacts on colored frames.