Deoldify Vapoursynth filter

[Dan64]

    I changed vsdeoldify to use internally the full range, previously vsdeoldify was using the limited range.

Shouldn't it use the range it is fed with?!? (or throw an error if the luma range is different then required)


I will:
a. remove the full range requirement for the filter
b. look into fixing the problems with RC5

No, please the current version in my opinion is working perfectly, I expect to receive in input a source with matrix=709 and full range.

In the current version, at the beginning of vsdeoldify I'm using the following code

if clip.format.id != vs.RGB24:
    # clip not in RGB24 format, it will be converted
    if (clip.format.color_family == "YUV"):
        clip = clip.resize.Bicubic(format=vs.RGB24, matrix_in_s="709", range_s="full", dither_type="error_diffusion")
    else:
        clip = clip.resize.Bicubic(format=vs.RGB24, range_s="full")

  
Previously I was using

if clip.format.id != vs.RGB24:
   # clip not in RGB24 format, it will be converted
   if (clip.format.color_family == "YUV"):
      clip = clip.resize.Bicubic(format=vs.RGB24, matrix_in_s="709", range_s="limited", dither_type="error_diffusion")
    else:
      clip = clip.resize.Bicubic(format=vs.RGB24, range_s="limited")

Moreover, previously when It was necessary a change from RGB24 to YUV and then back to RGB24

I was a code like

clip = clip.resize.Bicubic(format=vs.YUV444PS, matrix_s="709", range_s="limited")
....
....
clip_rgb = clip.resize.Bicubic(format=vs.RGB24, matrix_in_s="709", range_s="limited", dither_type="error_diffusion")

now I'm using

clip = clip.resize.Bicubic(format=vs.YUV444PS, matrix_s="709", range_s="full")
...
...
clip_rgb = clip.resize.Bicubic(format=vs.RGB24, matrix_in_s="709", range_s="full", dither_type="error_diffusion")

So this version is expecting in input a RGB24 clip with matrix=709 and range full.

Dan