This forum uses cookies
This forum makes use of cookies to store your login information if you are registered, and your last visit if you are not. Cookies are small text documents stored on your computer; the cookies set by this forum can only be used on this website and pose no security risk. Cookies on this forum also track the specific topics you have read and when you last read them. Please confirm whether you accept or reject these cookies being set.

A cookie will be stored in your browser regardless of choice to prevent you being asked this question again. You will be able to change your cookie settings at any time using the link in the footer.

[BUG] Merge mask not more working
#1
Hello Selur,

  I'm using Hybrid 2023.12.02.1. 
  I enabled the Vapoursynth->Misc->UI->Show "Merge"-controls
  But the merge is not more working.
  
  The generated code is the following

mergeClip = clip
## Starting applying 'limit' masked filtering for vsCodeFormer
mergeClipMask = mergeClip
mergeClipMask = core.resize.Bicubic(clip=mergeClipMask, format=vs.RGB24, matrix_in_s="709", range_s="limited", dither_type="error_diffusion")
mergeClipMask = core.resize.Bicubic(clip=mergeClipMask, format=vs.GRAY8, matrix_s="709", range_s="limited")
mergeClipMask = core.std.BinarizeMask(mergeClipMask, 60)
mergeClipFiltered = mergeClip
# changing range from limited to full range
mergeClipFiltered = core.resize.Bicubic(mergeClipFiltered, range_in_s="limited", range_s="full")
# Setting color range to PC (full) range.
mergeClipFiltered = core.std.SetFrameProp(clip=mergeClipFiltered, prop="_ColorRange", intval=0)
# adjusting color space from YUV420P10 to RGB24 for vsCodeFormer
mergeClipFiltered = core.resize.Bicubic(clip=mergeClipFiltered, format=vs.RGB24, matrix_in_s="709", range_s="full", dither_type="error_diffusion")
# Blind Face Restoration using CodeFormer
from vscodeformer import codeformer as CodeFormer
mergeClipFiltered = CodeFormer(clip=mergeClipFiltered, upscale=1, weight=0.800) # 1280x692
# changing range from full to limited range
mergeClipFiltered = core.resize.Bicubic(mergeClipFiltered, range_in_s="full", range_s="limited")
mergeClipFiltered = core.resize.Bicubic(clip=mergeClipFiltered, format=vs.YUV444P8, matrix_s="709", range_s="limited")
clipfiltered = core.resize.Bicubic(clip=clipfiltered, format=vs.YUV444P8, range_s="limited")
clipfiltered = core.std.Merge(mergeClipFiltered,clipfiltered,[0.5, 0.5, 0.5]) # merge filtered and unfiltered by plane
mergeClip = core.resize.Bicubic(clip=mergeClip, format=vs.YUV444P8, range_s="limited", dither_type="error_diffusion")
mergeClipMask = core.resize.Bicubic(clip=mergeClipMask, format=vs.YUV444P8, range_s="limited")
mergeClip = core.std.MaskedMerge(mergeClip, mergeClipFiltered, mergeClipMask) # LimitMask
## Finished applying 'LimitMask' masked filtering for vsCodeFormer

  As you can see there is a reference to "clipfiltered" but this variable was never defined.

  Moreover I'm not sure that this merge will work as the "weighted" resizer with method "simple weight" that was introduced within the "Resize" page.

  Could you check ?

Thanks,
Dan
Reply


Messages In This Thread
Merge mask not more working - by Dan64 - 05.01.2024, 17:26
RE: Merge mask not more working - by Selur - 05.01.2024, 18:22
RE: Merge mask not more working - by Selur - 05.01.2024, 18:39
RE: Merge mask not more working - by Dan64 - 05.01.2024, 19:30
RE: Merge mask not more working - by Selur - 05.01.2024, 19:33
RE: Merge mask not more working - by Selur - 05.01.2024, 20:41
RE: Merge mask not more working - by Dan64 - 05.01.2024, 21:13

Forum Jump:


Users browsing this thread: 1 Guest(s)