Deoldify Vapoursynth filter

[Dan64]

Hello Selur,

  I attached the RC1 of version 4.6.5.
  Respect to the previous version I applied the following changes:

  Function: HAVC_main()

  1) removed from the list of parameters allowed in VideoTune: 'DeOldify', 'DDColor'
  2) added new parameter ColorModel, with the following allowed values:

                                    'Video+Artistic'  (default)
                                    'Video+ModelScope'
                                    'Video+Siggraph17'
                                    'Video+ECCV16'
                                    'DeOldify(Video)'
                                    'DDColor(Artistic)'
                                    'DDColor(ModelScope)'
                                    'Zhang(Siggraph17)'
                                    'Zhang(ECCV16)'


  This change was necessary to give more flexibility to select the color models (which were increased in the last version) using the Presets in HAVC_main.

  The change requires to modify the Hybrid GUI to manage the new Preset: Color Model.

  Moreover is necessary to FIX the GUI as described in the following picture

 


Thanks,
Dan

[Selur]

Uploaded an updated Hybrid_deoldify version for testing.

Cu Selur

[Dan64]

The section "Coloring" (recently introduced) it's Okay e don't have to be changed, please revert it as shown in the figure below:

 

What have to be changed is the column with parameters for HAVC_main as shown in the picture below:


It is necessary to add a new Preset named: Color Model

Thanks,
Dan

[Selur]

Uploaded an updated Hybrid_deoldify version for testing.
1. the changes in the 'Color Preset' will not reflect in the custom section, since that would require me reading your whole code again,... (did that a few times not doing that again)
2. so I have no clue whether the command lines generated are as they should be. (since I have no clue whether my impression that there are tons of additional changes that I'm not aware of)

I'm strongly thinking about spending another weekend rewriting the whole DeOldify support in Hybrid (since adjusting it seems to get more and more complicated) and dropping the custom section and limit the support to the left row of settings (the presets) and the 'Exemplar Models'
current ui:

future ui:

If a user wants more control than that, he would have to write its own code in a custom section.
Trying to keep the 'custom section' does not seem sustainable at all.

Cu Selur

[Selur]

Send you a new link to Hybrid_new_deoldify where I removed the custom section (deleting a few thousand lines of code) and thus limiting the DeOldify support to just HAVC_main.

Cu Selur

[Dan64]

I will not release the version 4.6.5
Please don't apply any change to Hybrid, the custom section is necessary.

Dan

[Selur]

I am willing to write new code to add a custom section if you can provide and detailed overview what each of the settings of the 'preset options':

should do.
Me having to read tons of your code and trying to figure out what interacts with what is no option.

I will not release the version 4.6.5

You can decide.

Cu Selur