30.03.2024, 00:39
I changed the functions parameters as you suggested.
I performed also the following changes:
1) removed the method: Adaptive Luma Merge
2) moved fp16 flag in ddcolor_p
3) split the parameters of the 2 combining methods: CMC, LMM
4) assigned a dedicated flag to: invert clips merge
I performed also the following changes:
1) removed the filter chroma limiter
All the parameters have the suffix "_p", when the list contains only 1 element I substitute the list with a simple python variable, but I can keep the list (let me know)
I counted 36 parameters (excluding clips and enable/disable list flags), it is still an high number, but you have to consider that there are 2 coloring filters, 3 merge methods and 4 filters
Let me know I have to apply additional changes.
Thanks,
Dan
def ddeoldify(
clip: vs.VideoNode, method: int = 2, mweight: float = 0.4, deoldify_p: list = [0, 24, 1.0, 0.0], ddcolor_p: list = [1, 24, 1.0, 0.0, True], ddtweak: bool = False, ddtweak_p: list = [0.0, 1.0, 1.0, False, 0.4, 0.4], CMC_p: float = 0.2, LMM_p: list = [0.3, 0.6, 1.0], dark: bool = False, dark_p: list = [0.2, 0.8], chrez: bool = True, cmb_inv: bool = False, device_index: int = 0, torch_dir: str = model_dir) -> vs.VideoNode:
I performed also the following changes:
1) removed the method: Adaptive Luma Merge
2) moved fp16 flag in ddcolor_p
3) split the parameters of the 2 combining methods: CMC, LMM
4) assigned a dedicated flag to: invert clips merge
def ddeoldify_stabilizer(clip: vs.VideoNode, smooth: bool = False, smooth_p: list = [0.2, 0.7, 0.9, 0.1], stab: bool = True, stab_p: list = [5, 'A', 1, 60, 0.5, 0.8], chrez: bool = True, chrez_p: int = 24) -> vs.VideoNode:
I performed also the following changes:
1) removed the filter chroma limiter
All the parameters have the suffix "_p", when the list contains only 1 element I substitute the list with a simple python variable, but I can keep the list (let me know)
I counted 36 parameters (excluding clips and enable/disable list flags), it is still an high number, but you have to consider that there are 2 coloring filters, 3 merge methods and 4 filters
Let me know I have to apply additional changes.
Thanks,
Dan