This forum uses cookies
This forum makes use of cookies to store your login information if you are registered, and your last visit if you are not. Cookies are small text documents stored on your computer; the cookies set by this forum can only be used on this website and pose no security risk. Cookies on this forum also track the specific topics you have read and when you last read them. Please confirm whether you accept or reject these cookies being set.

A cookie will be stored in your browser regardless of choice to prevent you being asked this question again. You will be able to change your cookie settings at any time using the link in the footer.

Deoldify Vapoursynth filter
Ah, found the mistake.
=> updated download

Cu Selur
Reply
Here the new RC5 with the corrected descriptions.

Dan


Attached Files
.zip   vsdeoldify-3.0.0_RC5.zip (Size: 251,51 KB / Downloads: 25)
Reply
Nice, last download should still work.

Cu Selur
Reply
I found the following issues:

1) The “auto” parameter for render_factor in ddcolor is not managed
2) It is not managed the “render_factor” in  ddeoldify_stabilizer you can set it = max(ddcolor_rf, deoldify_rf)
3) most of the descriptions need to be updated with the last RC5

In the last RC5, the default for "stab" is False and not more True, and need to be managed

Thanks,
Dan



T
Reply
updated the download (had no time to test)

Cu Selur
Reply
All the issues fixed with the only exception of "auto" setting for ddcolor

When "auto" is checked should be generate the following code

ddcolor_p=[1, 0, 1, 0, True]

instead of is generated the following code

ddcolor_p=[1, 24, 1, 0, True]

Dan
Reply
you wrote to use 'max(ddcolor_rf, deoldify_rf)' and sice ddcolor_rf is 0 'ddcolor_p=[1, 0, 1, 0, True]' is used,...
=> this is what you asked for,...
Reply
I adjusted the code to set zero if one of the two is zero and use the max of them otherwise.
(updated download)

Cu Selur
Reply
Ok, it is better to remove the "auto" option in the GUI. 
The users should be able to know what value to use, if not the default value is good enough.

Thanks,
Dan
Reply
How is render_factor calculated when auto is enabled?
(not at home atm.)
If Hybrid has the values too, I could adjust Hybri accordingly to set render_factor to that value when 'auto' is enabled.

Cu Selur
Reply


Forum Jump:


Users browsing this thread: 3 Guest(s)