Posts: 10.598
Threads: 57
Joined: May 2017
Ah, found the mistake.
=> updated download
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 750
Threads: 72
Joined: Feb 2020
Here the new RC5 with the corrected descriptions.
Dan
Attached Files
vsdeoldify-3.0.0_RC5.zip (Size: 251,51 KB / Downloads: 30)
Posts: 10.598
Threads: 57
Joined: May 2017
Nice, last download should still work.
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 750
Threads: 72
Joined: Feb 2020
I found the following issues:
1) The “auto” parameter for render_factor in ddcolor is not managed
2) It is not managed the “render_factor” in ddeoldify_stabilizer you can set it = max(ddcolor_rf, deoldify_rf)
3) most of the descriptions need to be updated with the last RC5
In the last RC5, the default for "stab" is False and not more True, and need to be managed
Thanks,
Dan
T
Posts: 10.598
Threads: 57
Joined: May 2017
updated the download (had no time to test)
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 750
Threads: 72
Joined: Feb 2020
All the issues fixed with the only exception of "auto" setting for ddcolor
When "auto" is checked should be generate the following code
ddcolor_p=[1, 0, 1, 0, True]
instead of is generated the following code
ddcolor_p=[1, 24, 1, 0, True]
Dan
Posts: 10.598
Threads: 57
Joined: May 2017
you wrote to use 'max(ddcolor_rf, deoldify_rf)' and sice ddcolor_rf is 0 'ddcolor_p=[1, 0, 1, 0, True]' is used,...
=> this is what you asked for,...
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 10.598
Threads: 57
Joined: May 2017
I adjusted the code to set zero if one of the two is zero and use the max of them otherwise.
(updated download)
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 750
Threads: 72
Joined: Feb 2020
Ok, it is better to remove the "auto" option in the GUI.
The users should be able to know what value to use, if not the default value is good enough.
Thanks,
Dan
Posts: 10.598
Threads: 57
Joined: May 2017
How is render_factor calculated when auto is enabled?
(not at home atm.)
If Hybrid has the values too, I could adjust Hybri accordingly to set render_factor to that value when 'auto' is enabled.
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.