Possible typo Crashing Temporal filter.

[Wisperer]

It is an issue with the VIVTC Filter when using QTGMC as the de-interlacer. I was able to replicate the crash on the Stable 2020.12.13 build  with VIVTC/QTGMC combo and I was able to get a finished encode on the 2020.12.25 Dev build with the just QTGMC  filter or VIVTC with NNEEDI3.

I'll attach logs for all the Runs.

---

Double post because of the attachment Limit.

[Selur]

Problem is:
a. the Vapoursynth Preview works fine
b. it doesn't crash here so far (will run more tests today, but I already converted my 7 DVD test images)

VIVTC with QTGMC crashes
and
VIVTC with NNEDI3 works

Since it does not crash here:

• Does it crash if you use a faster QTGMC preset than 'very slow' ? (I assume you did use this preset with the QTGMC only tests too, right?)
  
• What CPU are you using?
  
• Does this only happen with that one file or also with other files? (preferable not created by MakeMKV)
  
• Does it also happen if "x264->Misc->Misc->Automatically->Create qpfile for chapters" is disabled?
  
• Does it happen with another encoder than x264?
  
• Are your Vapoursynth filters up-to-date?
  
• What Vapoursynth version are you using?
  

Atm. I suspect that it's one of the filters that is causing problems with your cpu:
looking at the filters (that are used in the QTGMC and not the NNEDI3 case):

core.std.LoadPlugin(path="/home/fletcher/.hybrid/vsplugins/libaddgrain.so")
core.std.LoadPlugin(path="/home/fletcher/.hybrid/vsplugins/libneofft3d.so")
core.std.LoadPlugin(path="/home/fletcher/.hybrid/vsplugins/libdfttest.so")
core.std.LoadPlugin(path="/home/fletcher/.hybrid/vsplugins/libeedi3m.so")
core.std.LoadPlugin(path="/home/fletcher/.hybrid/vsplugins/libmvtools.so")
core.std.LoadPlugin(path="/home/fletcher/.hybrid/vsplugins/libtemporalsoften.so")
core.std.LoadPlugin(path="/home/fletcher/.hybrid/vsplugins/libscenechange.so")
core.std.LoadPlugin(path="/home/fletcher/.hybrid/vsplugins/libfmtconv.so")

the newest of these is libneofft3d, so that is the prime candidate for me atm.
May be using fft3dfilter.so instead of libneofft3d.so would work.

The havsfunc.py from https://github.com/Selur/VapoursynthScriptsInHybrid uses either libneofft3d.so and if that isn't found fft3dfilter.so, so replacing the libneofft3d.so call might help.
->I'll create a modified Hybrid binary for Linux that loads fft3dfilter.so. Will send you a link via PM once I finished the build.

Cu Selur

[Wisperer]

Yeah that just crashes during Start up. GDB log since Normal log didn't say anything. I'm poking my QT 5 install ATM though. it may be on me end only.

fletcher@fletcher-desktop: ~/Downloads/hybrid-dev $ gdb ./Hybrid
GNU gdb (GDB) 10.1
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ./Hybrid...
(No debugging symbols found in ./Hybrid)
(gdb) run
Starting program: /home/fletcher/Downloads/hybrid-dev/Hybrid
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
  no file '/home/fletcher/Downloads/hybrid-dev/misc.ini' found,..
Detected '/home/fletcher/.hybrid/misc.ini',...
[New Thread 0x7ffff2997640 (LWP 4431)]
[New Thread 0x7ffff0c01640 (LWP 4432)]
[New Thread 0x7fffebfff640 (LWP 4433)]
[New Thread 0x7fffeaad6640 (LWP 4434)]
[New Thread 0x7fffea2d5640 (LWP 4435)]
[New Thread 0x7fffe9ad4640 (LWP 4436)]
[New Thread 0x7fffe92d3640 (LWP 4437)]
[New Thread 0x7fffe8ad2640 (LWP 4438)]
[New Thread 0x7fffcffff640 (LWP 4439)]
[New Thread 0x7fffcf7fe640 (LWP 4440)]
[New Thread 0x7fffceffd640 (LWP 4441)]
[New Thread 0x7fffce7fc640 (LWP 4442)]
[New Thread 0x7fffcdffb640 (LWP 4443)]
[New Thread 0x7fffcd7fa640 (LWP 4444)]
[New Thread 0x7fffccff9640 (LWP 4445)]
[New Thread 0x7fffabfff640 (LWP 4446)]
[New Thread 0x7fffa3fff640 (LWP 4447)]
[New Thread 0x7fffab7fe640 (LWP 4448)]
[New Thread 0x7fffaaffd640 (LWP 4449)]
[New Thread 0x7fffaa7fc640 (LWP 4450)]
Hybrid 2020.12.28.1 by Selur
Pre-GUI initialization starting 12:41:20.520
Checking for styles,...
Checking for inputs,...
Checking for global profile,...
Checking for auto add,...
Loading resources:
  model versions,...
  raw video file extensions,...
  raw audio file extensions,...
  raw subtitle file extensions,...
  index file extensions,...
  cuda capable cards,..
  ogg extensions,...
  wmv extensions,...
  mp4 extensions,...
  mp3 extensions,...
  mpeg extensions,...
  tsMuxeR extensions,...
  raw output extensions,...
  mov extensions,...
  matroska extensions,...
  subcodes,...
  languages,...
  additional mkv tags,...
  format <> number mapping,...
  avc level -> vbv max bitrate mapping,...
  avc level -> max mps mapping,...
  avc level -> max buffer mapping,...
  avc level -> max dpb mapping for main tier,...
  avc level -> max dpb mapping for high tier,...
  avc level -> max dpb mapping for level,...
  avc level -> max frame size mapping,...
  qtgmc 720x576 memory usage
  qtgmc 1280x720 memory usage
  qtgmc 1920x1080 memory usage
  DNxHD profiles,...
  Avisynth model combis,...
  fraction lists,...
  fraction conversions,...
Creating application,...
  setting application path,...
  application home: /home/fletcher/Downloads/hybrid-dev
  application data path: /home/fletcher/.hybrid
Loading values from: /home/fletcher/.hybrid/misc.ini
  Vapoursynth plugin path: /home/fletcher/.hybrid/vsplugins
'/home/fletcher/.hybrid/vsscripts' doesn't exist,..
  iIgnored tools: NVEnc
  enabling Vapoursynth support
  using vsPluginsPath: /home/fletcher/.hybrid/vsplugins
  using vsScriptPath: ./vsscripts
GUI initialization starting 12:41:20.543
--Type <RET> for more, q to quit, c to continue without paging--c

Thread 1 "Hybrid" received signal SIGSEGV, Segmentation fault.
0x00007ffff7257d90 in QWindow::screen() const () from /usr/lib/libQt5Gui.so.5

[Selur]

Nope it's my fault. :/
I did rewrite some stuff to be Qt6 compatible, that included some changes with QScreen and QWindow.
The code worked fine on Windows and Mac.
-> I'll do some testing.

[Wisperer]

And to respond to the questions (Sorry just now saw them)

• Does it crash if you use a faster QTGMC preset than 'very slow' ? (I assume you did use this preset with the QTGMC only tests too, right?) -Just using QTGMC crashes it. Speed doesn't matter. That was my first thought to be honest.
  
  
• What CPU are you using? Ryzen 2700X 8c/16t
  
  
• Does this only happen with that one file or also with other files? (preferable not created by MakeMKV) - Tested several files but all from from MakeMKV though. Consistently crashed at about 98-99% done no matter file length.
  
  
• Does it also happen if "x264->Misc->Misc->Automatically->Create qpfile for chapters" is disabled? 
  
  
• Does it happen with another encoder than x264? Yes. But only with the VIVTC/QTGMC combo like x264
  
  
• Are your Vapoursynth filters up-to-date? Yup. I did that after you pointed it out and that's when this issue cropped up.
  
  
• What Vapoursynth version are you using? 
  

VapourSynth Video Processing Library
Copyright (c) 2012-2020 Fredrik Mellbin
Core R52
API R3.6

[Selur]

Okay, seems all 'fine'.
Still it would be interesting to know if non-MakeMKV (and best non MPEG-2 files) also have the problem and if disabling the qpfile helps.

Cu Selur

[Wisperer]

oh This Video is MPEG 4 Bluray. or at least that's what mediainfo reports.

and no qpfile made no difference.

BUT BUT BUT!!!!!
I compiled libneofft3d.so from source myself and substituted the version you gave me and the decoder/encoder work just fine.

[Selur]

Nice! (I compile on Ubuntu so simply using the Ubuntu files on Arch can cause problems )
I also uploaded a hopefully fixed dev version (same link).

Cu Selur

Ps.: Also nice to know what really caused the issue.

[Wisperer]

Finally got to testing that debug build. Good new is can get it to launch now, but only if I use my system libs. using the supplied ones just results in a generic crash. However it still crashes when trying in anything into the input. Logs below.

[Selur]

Forget the files of the first download those were build on and for Ubuntu.
For all other Linux distributions I only offer the Hybrid binary + links to the Vapoursynth scripts used in Hybrid.

Cu Selur

Ps.: gdb output doesn't help since those are not debug builds.