Deoldify Vapoursynth filter

[Selur]

'video' is a bad choice of word here.
We need to get that wording into something understandable.
Is it:

# 0  "HAVC only, no references";  // ScFrameDir = None
# 1  "references frames generated from the input (by HAVC)"; // ScFrameDir => None
# 2  "reference frames automatically taken from ref clip  (by HAVC)"; // ScFrameDir => file path
# 3  "reference frames automatically taken from the input (by external method)"; // ScFrameDir => None
# 4  "reference frames automatically taken from ref clip (by external method)"; // ScFrameDir => dir path
# 5  "taking input as reference clip (for external method)";  // ScFrameDir => None
# 6  "reference clip (for external method)";  // ScFrameDir => file path

?

Cu Selur

Ps.: Updated Hybrid_deoldify.

[Dan64]

The correct definition is the following

0 = HAVC same as video  // clipRef=HAVC, ScFrameDir = None
1 = HAVC + RF same as video  // clipRef=HAVC, ScFrameDir => dir path
2 = HAVC + RF different from video  // clipRef=HAVC, ScFrameDir => dir path
3 = external RF same as video  // clipRef = None, ScFrameDir => dir path
4 = external RF different from video  // clipRef = None, ScFrameDir => dir path
5 = external ClipRef same as video  // clipRef=VideoClip, ScFrameDir => file path
6 = external ClipRef different from video  // clipRef=VideoClip, ScFrameDir => file path

The term "same as video" imply that the external frame provided (from file or clip) is equal to the frame to be colored with the only exception of colors.

Since the custom section was removed, I added more ColorModel

'Video+Artistic'
'Stable+Artistic'      [new]
'Video+ModelScope'
'Stable+ModelScope'    [new]
'Artistic+Modelscope'  [new]
'Video+Siggraph17'
'Video+ECCV16'
'DeOldify(Video)'
'DeOldify(Stable)'     [new]
'DeOldify(Artistic)'   [new]
'DDColor(Artistic)'
'DDColor(ModelScope)'
'Zhang(Siggraph17)'
'Zhang(ECCV16)'

Added new RC7 with the new color models.

Dan

[Selur]

The term "same as video" imply that the frame provided (from file o clip) is equal to the frame to be colored with the only exception of colors.

Ahhhh,... okay.


Updated Hybrid_deoldify.

Cu Selur

[Dan64]

Found a problem with RefMerge because is disabled, here the full mapping

0 = HAVC same as video  // clipRef=HAVC, ScFrameDir = None, RefMerge Enabled
1 = HAVC + RF same as video  // clipRef=HAVC, ScFrameDir => dir path, RefMerge Enabled
2 = HAVC + RF different from video  // clipRef=HAVC, ScFrameDir => dir path, RefMerge Disabled
3 = external RF same as video  // clipRef = None, ScFrameDir => dir path, RefMerge Disabled
4 = external RF different from video  // clipRef = None, ScFrameDir => dir path, RefMerge Disabled
5 = external ClipRef same as video  // clipRef=VideoClip, ScFrameDir => file path, RefMerge Enabled
6 = external ClipRef different from video  // clipRef=VideoClip, ScFrameDir => file path, RefMerge Disabled

Ref Merge requires not only that the source of RF is "same as video" but also that the RF is provided by a video clip produced by HAVC (methods: 0, 1) or externally by another tool (method 5)

I added the new value "None" to preset ColorTune (in the GUI is called "Denoise")
Now allowed values are:
            'None'
            'Light',  (default)
            'Medium',
            'Strong',

Since the custom section was removed, it is necessary to add a new preset to define the combination methods, the new preset is called CombMethod

CombMethod: Method used to combine coloring models with (+):
            Allowed values are:
               'Simple'
               'Constrained-Chroma'
               'Luma-Masked'
               'Adaptive-Luma'

If the selected ColorModel does not contain the string "+" (like 'Video+Artistic') CombMethod should be Disabled.


I attached the new RC8.

Thanks,
Dan

[Selur]

• added 'none' as a 'ColorTune'-option (Hybrid will set None when this is selected, not "None")
  
• adjusted 'RefMerge' en-/disabling
  
• 'CombMethod'-parameter
  
• rearranged havc gui elements
  

Updated Hybrid_deoldify. (RC7 does not include 'CombMethod' => "HAVC_main() got an unexpected keyword argument 'CombMethod'").

Cu Selur

[Dan64]

Updated Hybrid_deoldify. (RC7 does not include 'CombMethod' => "HAVC_main() got an unexpected keyword argument 'CombMethod'").

Cu Selur

In effect this method was included in RC8, attached in the previous post.

Thanks,
Dan

[Selur]

Ah missed RC8 code should be fine then.

[Selur]

updated Hybrid_deoldify, remved sc_debug

[Dan64]

When is selected value "None" for the preset ColorTune (in the GUI is called "Denoise")
In the script is passed None instead of "none".



Dan

[Selur]

updated Hybrid_deoldify to pass a string