Deoldify Vapoursynth filter

[Dan64]

Hello Selur,

   In the current dev are missing the following values in BlackWhiteTune:

'Light+Custom',
'Medium+Custom',
'Strong+Custom'
'Light+Restore',
'Medium+Restore',
'Strong+Restore'

 
If you don't like this solution, you can add above "B&W mode" another combo-box called "B&W Restore" with the following values

'none'
'custom'
'default'

 
The parameter "B&W Restore" in the code will be called BlackWhiteRestore and should have the same behaviour of "B&W mode"
 
Please let me know what do you prefer so that I can provide a new RC with the new parameter.

Thanks,
Dan

[Selur]

In the current dev are missing the following values in BlackWhiteTune:

That is correct, like I wrote:

That seems unnecessary, since using 'light/medium/strong' + enabling 'Exemplar Models' is the same as 'light/medium/strong+Custom'.
And 'light/medium/strong+Restore' does not make any sense to me. (since it should be a preset for 'exemplar models')

From what you described, those are presets for other options, which still could be adjusted manually.

Cu Selur

[Dan64]

Just to clarify better these are the situations that need to be managed in Hybrid:

1) standard HAVC without BlackWhiteTune adjustments  -> managed with BlackWhiteTune='none'
2) standard HAVC with BlackWhiteTune adjustments  -> managed with BlackWhiteTune != 'none'
3) standard HAVC with BlackWhiteTune Restore (it is a more complex strategy that will be explained in the guide)  -> settings = ?
4) apply BlackWhiteTune adjustments on a clip already colored -> managed with BlackWhiteTune != 'none'  and DeepExMethod = 5
5) apply BlackWhiteTune Restore  (with user parameters) on a clip already colored -> settings ? 
6) apply BlackWhiteTune Restore (with optimal parameters) on a clip already colored -> settings ?

with the current GUI I'm able to manage only 3 cases out of 6.

Dan

[Selur]

I thought the GUI would only cover 1&2.

But from the looks of it, I don't really understand what BlackWhiteTune should do.
I assumed it would always be applied after on the colored image.

This parameter allows to improve contrast and luminosity of frames colored with HAVC.

in the case are used the settings with "+custom" will be used the parameters specified in the "Exemplar Model", in this case should be used the ColorMNet model (but the user can try also the other models). If are used the settings with "+restore", the user settings will be ignored and will be used the internal settings.

Is my conclusion that:
a. BlackWhiteTune with '+custom' requires 'Exemplar Model' turned on, correct?
(So in the gui, if you select a '+custom' BlackWhiteTune value, the 'Exemplar Model' would need to be forced to be enabled. User can't disable it.)
If this is correct, the 'custom' BlackWhiteTune values should not be there, since adding an option to basically enforcing 'Exemplar Model' doesn't make sense.
If this is not correct, try to explain it, please.

b. BlackWhiteTune with '+restore' requires 'Exemplar Model' turned on and disabled and also set to specific settings, correct?
(So in the gui, if you select a '+restore' BlackWhiteTune value, the 'Exemplar Model' would need to be forced to be enabled. User can't disable it. And the content of the GroupBox would need to stay disabled while forced to specific values.)
If this is correct, then this the 'restore' values should not be there, instead there should an additional sub option i.e. AutoBlackWhite which is basically enforcing preset settings for 'Exemplar Model'.
If this is wrong, try to explain it, please.

Cu Selur

[Dan64]

Ok, I will try to explain better.

Case: 1 & 2 are simply to understand and should be the cases more frequent.
Case: 4, I added this case to be able to quickly adjust the colored movies with the previous version of HAVC, in this case is not necessary to recolor again the clip.
Case: 3, This is a complex strategy (which requires at last a RTX 4070ti) which split the color processes in 2 steps: 
       1) in the first step will be used HAVC with Deep-Exemplar and freq=5, just to speed-up the first coloring step (BlackWhiteTune will not be used in this step);    
       2) in the second step the clip previously colored will be stabilized using ColorMNet, which provides dull colors, and will be applied BlackWhiteTune to improve the final colors 
Case: 6, is similar to case 4, but in this case  BlackWhiteTune will be applied using the process described in Case 3.2
Case: 5, is similar to 6, but in this case the stabilization parameters will be taken from the GUI.

The need to add  "B&W Restore"  is to manage the cases 3, 5, 6. In all these cases the "Exemplar Models" will be used twice with different values. 
To simplify the GUI management I proposed to add  "B&W Restore".

Dan

[Selur]

Case 1&2: should be covered by Hybrid as it is atm., correct?

Case: 4, I added this case to be able to quickly adjust the colored movies with the previous version of HAVC, in this case is not necessary to recolor again the clip.

What? Please rephrase that.
Did you want to write:

I added this case to be able to quickly adjust the already colored movies, which were colored using the previous version of HAVC.
In this case, it is not necessary to recolor again the clip.

If that is what you wanted to say, then this should be a separate filter in Hybrid (not a option of HAVC_main) which should be called using for example with something like

clip = havc.ColorPostProcessing(clip, tune=.., mode=...)

.

Case: 6, is similar to case 4, but in this case BlackWhiteTune will be applied using the process described in Case 3.2

If this too is meant to be applied to improve and stabilize an already colored clip, then this too should not be part of HAVC_main.
The ColorPostProcessing, should be extended to

clip = havc.ColorPostProcessing(clip, tune=.., mode=..., stabilize=True)

.
(side note: such a filter would be located under Color->Misc not Color->Coloring in Hybrid and maybe named 'ColorImprovement(HAVC)')

Case: 5, is similar to 6, but in this case the stabilization parameters will be taken from the GUI.

Okay,.. then you should extend ColorPostProcessing with the necessary options.

Case: 3, This is a complex strategy (which requires at last a RTX 4070ti) which split the color processes in 2 steps:
1) in the first step will be used HAVC with Deep-Exemplar and freq=5, just to speed-up the first coloring step (BlackWhiteTune will not be used in this step);
2) in the second step the clip previously colored will be stabilized using ColorMNet, which provides dull colors, and will be applied BlackWhiteTune to improve the final colors

Sounds to me, like this should be: done with two filter calls (user enabling two separate filters)
1. 'HAVC' (havc.HAVC_main(...))
2. 'ColorImprovement(HAVC)' (havc.ColorPostProcessing(...))

Cu Selur