Hybrid adjusting = CTD

[ToiletDuck]

Helluh,

What do you hear ... what do you say 

Seems , some x264 + crop/resize misc settings do agree to disagree again   !


Hybrid crashes to desktop when i try to adjust the following AND (important) ONLY when a media file is already loaded/opened !

when i enable strict bd policy in x264 , then afterwards enable picture crop put in some vallue's , then enable the checkbox "adjust letterbox to crop" in misc sub pane under resiz/crop , hybrid gets an seizure, stops responding and exits to desktop   

Hybrid / Bd strict settings does like to do its own thing and rather disregards user input for pretty much anything i guess ehh hehehe 😭


Debug attached..


Ta TA
Toilet (°^ °')

[Selur]

2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: adjusting output resolution to letterbox.
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: adjust output resolution,...
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: inputWidth: 1920
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: inputHeight: 1080
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: adjusting output resolution to letterbox.
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: adjust output resolution,...
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: inputWidth: 1920
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: inputHeight: 1080

seems like that triggers some kind of infinite loop,...
Will try to look at after work.

Hybrid crashes to desktop when i try to adjust the following AND (important) ONLY when a media file is already loaded/opened !

when i enable strict bd policy in x264 , then afterwards enable picture crop put in some vallue's , then enable the checkbox "adjust letterbox to crop" in misc sub pane under resiz/crop , hybrid gets an seizure, stops responding and exits to desktop

So your steps are:

• start Hybrid
  
• loading a source file
  
• enable "x264->Base->Restiction Settings->Hardware" and setting it to 'Blu-ray/AVCHD'
  
• enable "Crop/Resize->Base->Picture Crop" enter some crop values (in what order?)
  
• enable "Crop/Resize->Misc->Misc->Adjust Letterbox to Crop"
  

Correct? Or do you use a different order of things?
Since combining "Adjust Letterbox to Crop" doesn't make sense in for 'Blu-ray/AVCHD' restriction, since Letterbox should be fixed in this case I suspect I'll endup adjusting the code to ignore "Adjust Letterbox to Crop" when hardware restriction 'Blu-ray/AVCHD' is enabled.

Cu Selur

[Selur]

Send you a link to a dev version which might fix the problem. (not sure since I don't know for sure I used the same order of settings you mentioned)

Cu Selur

[ToiletDuck]

2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: adjusting output resolution to letterbox.
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: adjust output resolution,...
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: inputWidth: 1920
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: inputHeight: 1080
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: adjusting output resolution to letterbox.
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: adjust output resolution,...
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: inputWidth: 1920
2024.04.03 - 00:31:38_Windows 11 Version 23H2 (64bit)_2024.04.02.1 - level 9: inputHeight: 1080

seems like that triggers some kind of infinite loop,...
Will try to look at after work.

Yep, it looks like it does.

So your steps are:

• start Hybrid
  
• loading a source file
  
• enable "x264->Base->Restiction Settings->Hardware" and setting it to 'Blu-ray/AVCHD'
  
• enable "Crop/Resize->Base->Picture Crop" enter some crop values (in what order?)
  
• enable "Crop/Resize->Misc->Misc->Adjust Letterbox to Crop"
  

Correct? Or do you use a different order of things?
Since combining "Adjust Letterbox to Crop" doesn't make sense in for 'Blu-ray/AVCHD' restriction,  since Letterbox should be fixed in this case I suspect I'll endup adjusting the code to ignore "Adjust Letterbox to Crop" when hardware restriction 'Blu-ray/AVCHD' is enabled.
Cu Selur

Selur, i don't think it's so much the matter in which order i change some and what settings , but the problem is rather when i open / load a media file and try to change the mentioned settings, you see ?

I noticed that Hybrid tries to change some other values based on the values i enter at the same time when i enable that specific settings in the misc panel under crop/resize, at exactly that point hybrid stops responding and exits.. you see..

So, the proper order to reproduce this would be:

[*]start Hybrid
[*]enable "x264->Base->Restiction Settings->Hardware" and setting it to 'Blu-ray/AVCHD'
[*]enable "Crop/Resize->Misc->Misc->Adjust Letterbox to Crop"
[*]enable "Crop/Resize->Base->Picture Crop" DO NOT ENTER ANY values (NOT YET !!)

then..

[*]loading a source file
[*]NOW "try" to enter crop values ...




Ta TA

[Selur]

Okay, so the last version I send you fixes the problems, right?

[ToiletDuck]

Okay, so the last version I send you fixes the problems, right?

Still DL .. i'll keep you posted 

---

Update...

I see what you've done there to fix this, you disabled "Letterbox to Crop" in misc pane to fix it 

Work arround ?  Anyway, no more crashes..  that seems to have fixed it , for now 


Thanks

Ta Ta

---

Update 2:

When BD strict settings is enable, iam unable to create an custom output par !
Iam only able to choose between the predefined par output profiles which reduces the DAR to 720p !

Could you add a custom profile to work with strict settings my king  ?


Ta TA

[Selur]

Blu-ray does only allow specific PARs and resolutions.
see: https://forum.doom9.org/showthread.php?t=154533 (PAR <> SAR)
=> nothing to adjust.

Cu Selur

[ToiletDuck]

Blu-ray does only allow specific PARs and resolutions.
see: https://forum.doom9.org/showthread.php?t=154533 (PAR <> SAR)
=> nothing to adjust.

Cu Selur

Selur, the problem i now have when strict bd is enabled.  The resize under crop/resize pane is done automatically , right.

Noiw, when i load a media with following and valid values 1080p / 16:9 DAR.
And choose 1:1 par for example, it automaticallys lowers DAR to 1280x720 (720p) 
I can't change the height back to 1920x !  1280x720 is sudden the max value it reaches !

Bassically 1080p content automatically gets resized to 720p when strict bd settings is enabled!
Unless i reload the media file.. then i get back the original values of 1080p, untill i choose and pick par 1:1 !

Mind you, no crop is done (disabled) just using default strict settings ..  changing pars back and forward creates this issue !

That can't be right?

I know, this ↑ SENSITIVE topic for my King 


Ta Ta
Cu Toilet (°^ °)

[Selur]

I suspect you want to enable "Crop/Resize->Misc->On Source Change->Maximize resolution".

Maximize resolution:
When enabled Hybrid will automatically try to maximize the output resolution.
Available if hardware restriction is set to Blu-ray/AVCHD.

without it, Hybrid falls assumes you want the lower allowed resolution for 1:1 PAR, which is 720p.

Cu Selur

[ToiletDuck]

I suspect you want to enable "Crop/Resize->Misc->On Source Change->Maximize resolution".

Nope... guess again teehee 

Argh.. can't tease my king so much.. No , not Max Res (nothing changes , still maxed at 720p !), DAS but Max "letterbox" however did solved my (1080p → 720p) issue pretty much.

without it, Hybrid falls assumes you want the lower allowed resolution for 1:1 PAR, which is 720p.
Cu Selur

Toilet not like how hybrid thinks   .. 
Furthermore, does Cropping feature actually works using strict settings ?
I don't see NO CHANGE wotsoever to the internal picture and or black borders  !?

aaah... The FREEDOM of CUSTOMIZATION to my needs is just ... ☝️ 🤤👌  

Ta Ta
Toilet (°^ °)