[BUG] SCUNet crashes/not added to the vspipe?

[tailland]

installed:
Hybrid_dev_2025.01.27-202418.exe
vs-mlrt_2025.01.25.7z
VapoursynthR70_torch_2025.01.27.7z

Problem:
Tried denoising with scunet. Always found it to be quite useful.

* when normal scunet vs filter activated : job crashes instantly, with or without TRT option

* when scunet-mlrt filter activated: job is going through but no denoise filtering was done (regardless of backend option); high cpu but little gpu during job, so not part of the job?

Greetings.

[Selur]

Strange, will look at it after work and report Back.

Cu Selur

[Selur]

Can't reproduce this here. (deleted my Vapoursynth folder and took the one from the VapoursynthR70_torch_2025.01.27 download)
Both SCUNet with and without TRT enabled work fine here.
Does the Vapoursynth Preview show an error message if you open it?
When did you download VapoursynthR70_torch_2025.01.27 ? (iirc I updated the download once without changing the name)

Cu Selur

[tailland]

i downed and installed them all today. i will do some new  installation, reset and new runs.
btw what did the mlrt run log say? was scunet implemented? it ran with like 19fps on my machine, which is impossible with scunet included.

[Selur]

SCUNet none mlrt (https://github.com/HolyWu/vs-scunet) just added TRT support.

btw what did the mlrt run log say?

it doesn't use Vapoursynth at all Job queue doesn't contain a Vapoursynth script. (that's a bug I just fixed), but I wanted to wait till I knew what the problem with the torch version is before uploading a new dev.

Cu Selur

[Selur]

Uploaded a dev version which should fix the mlrt problem.
Will need a debug output of the Vapoursynth Preview or the info what error is reported there to look into the torch SCUNet not working for you.

Cu Selur

[tailland]

ok let's see...

- i reinstalled everything, disabled my xmp memory profile for stability.

trying to PREVIEW (3840*2160 h265 source):

* scunet (nonmlrt) without TRT option: vsviewer opens preview window, gpu 80%+ indefinetely, but nothing ever shows.
* scunet (nonmlrt) with TRT option: vsviewer.exe runs cpu at 5% indefinetely, no gpu%, no preview window opens.

*scunet (mlrt) with FP16 activated / backend ONNX (cpu) : preview window opens, cpu runs at 35% indefinetely (gpu 0% but 80gb ram usage), nothing shows.
*scunet (mlrt) with FP16 deactivated / backend ONNX (cpu) : preview window opens, cpu runs at 50% indefinetely (gpu 0% but 80gb ram usage), nothing shows.

*scunet (mlrt) with backend ONNX (cuda) : vsviewer opens preview window, gpu runs at 90+% indefinetely (30gb ram usage), nothing shows.

*scunet (mlrt) with FP16 activated / backend TensorRT: trtexec running at 85+% gpu, vsviewer runs at 0% pu, preview window doesn't show.  
*scunet (mlrt) with FP16 deactivated / backend TensorRT: trtexec running at 85+% gpu, vsviewer runs at 0% pu, preview window doesn't show. 

trying to export (same source):
scunet (nonmlrt) .. 80+% gpu usage indefinetely, no progress update whatsoever
scunet (mlrt)... 60% cpu use, 20-25% gpu indefinetely, 15fps .. final output has no cleaning done.

----
needless to say... this is not a problem with lower resolution sources.

oh wait, you have uploaded a new version, i will load and test it..

---

Hybrid_dev_2025.01.29-164543.exe

3840*2160 h265 source:

preview with scunet(mlrt) + onnx cpu +- fp16 : 80% cpu (with 50gb ram usage) 0% gpu indefinetely , preview window opens but shows nothing
preview with scunet(mlrt) + onnx cuda: 90+% gpu (with 35gb ram usage) indefinetely, preview window opens but shows nothing

export with scunet(mlrt) + onnyx cpu +-fp16: vspipe takes 45%+ cpu, 0% gpu, 80gb ram usage, indefinitely, no progress (ffmpeg is started but gets no action)
export with scunet(mlrt) + onnyx cuda: vspipe takes 90%+ gpu, 35gb ram usage, indefinitely, no progress (ffmpeg is started but gets no action)
export with scunet(mlrt) + tensort - ftp16: instacrash
export with scunet(mlrt) + tensort + ftp16: trtexec 90+% gpu indefinitely (only 4gb ram usage), no progress, vspipe + ffmpeg get no action.

but it's a good thing that the mlrt export doesn't just go through anymore with no actual application of the filter, amirite ? ^^

[Selur]

My guess is, that you are running out of VRAM and SCUNet is 'swapping'
=> does it work if you sue an SD source ?

[tailland]

scunet non-mlrt works with lower resolution sources.

scunet mlrt doesn't work (and i think it never did for me), it does the same thing as with the 4k source.
i've also tried to raise the number of tiles for gpu calculation...

result:
   
miniscule gpu %, and then.. nothing anymore.. complete no show with 0% vram used.

update: oh wait, it just took a bit more to show up.. however... split view: original shows, processed is just empty/black
   

[Selur]

Okay, torch SCUNet works.
Or not. Okay, try with the default settings.

For the mlrt version, since you aborted engine building before, try clearing your engine-folder. (temp folder if you didn't specify one)
There might be broken engine file there.
(Just to be sure, you are using latest mlrt&torch addon right?)