Posts: 10.598
Threads: 57
Joined: May 2017
You might also want to:
a. look into masking (especially for strong filters, sometimes masking helps)
b. try running spotless or similar after FeMaSR (that sometimes helps with artifacts)
As a side note: not sure how long FeMaSR will still be part of Hybrids addons, since HolyWu deleted https://github.com/HolyWu/vs-femasr and afaik. there is no alternative. So not using FeMaSR might be the right choice.
Quote:I shall prepare a more comprehensive comparison and share the results.
Looking forward to it.
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 37
Threads: 3
Joined: Mar 2022
Unfortunately, the noise is everywhere on these AVI clips so I am not sure if masking is a good idea. Once you have recommended such an approach to use for MTS files in which the noise was mostly present in bright areas like the sky or water. But these files and also 4K mp4 ones will be the topic of other threads.
I have tried the settings you recommended for these AVI files:
DeHalo: YAHR, Blur 1 and Depth 16
FineDeHalo: Default
DeRing: GLSL AntiRing defaults.
Question 1: Does FineDeHalo remove the halo effect even more?
Question 2: What does the GLSL AntiRing filter do? Is it responsible for the removal of some rings and jaggies from the clip?
All in all after this stage, I have tried the following filters:
1. MCDegrainSharp, Strength 3, Strength (sharp) 0.1-0.2, Strength (blur) 0.3, Threshold 400
or
2. Temporal Degrain Filtering level - pre and post-filtering step, other settings default; + SMDegrain Temporal radius 3, prefilter off or dfttest (spatial); this is Temporal Degrain AND SMDegrain together. It removes most of the artifacts, colours noise, etc. leading to quite clean footage without creating wax-like faces, etc. I must play with a few more settings to find out "the best" ones. Assuming I shall succeed, the next stage will be upscaling, maybe NNEDI3.
A few examples will be shared during the weekend and some comments/suggestions will welcome.
Posts: 10.598
Threads: 57
Joined: May 2017
Quote:Question 1: Does FineDeHalo remove the halo effect even more?
Compared to what? Against YAHR at the defaults: probably, yes.
Quote:Question 2: What does the GLSL AntiRing filter do? Is it responsible for the removal of some rings and jaggies from the clip?
it should help with rings/halos and the surrounding noise, but often is more aggressive than dehalo filters.
As a side note: sometimes it helps to apply a filter multiple times.
Quote:I must play with a few more settings to find out "the best" ones.
do that, usually that helps to understand that there are no settings that work equally well on all sources /scenes
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 36
Threads: 0
Joined: Oct 2022
@selur
When using FemaSR, i don't get the preview to see when i enable Tensor RT !
It sure starts the preparation, but doesn't finish ! No messages / warnings or errors show up either !
Atm, using 4060Ti..
Any suggestions?
cheers,
td
Posts: 10.598
Threads: 57
Joined: May 2017
Check that you use the latest drivers.
If that doesn't help, disable any GLSL based filters, as they seem to interfere with machine learning based filters.
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 36
Threads: 0
Joined: Oct 2022
(13.01.2024, 22:33)Selur Wrote: Check that you use the latest drivers.
If that doesn't help, disable any GLSL based filters, as they seem to interfere with machine learning based filters.
Cu Selur
Have disabled all additional filters ( to be sure) , no help there.
Atm, iam on driver 546.01 for several other issue's that i had using latest driver release..!
Must say, iam inclined to admit that the results of FemaSRx2 looks even better than ESRgan IMO.. But at such performance penalty ! I barely get 1 frame out of it, without Tensor RT enabled.. I bet , enabled i would get 3 maybe 4-5 fps i guess with the 4060ti..
While, ESRgan i get speeds up to 11 fps .. Wich would be my suggestion to Al74, still using an gtx1080 ..
Oh well..
Maybe 4070Ti-Super (ppl's new "super" hero -_-) will improve that a weebit
But.. it's WORTH it ... SD looks suddenly closer to HD ^^
cheers,
td
Posts: 10.598
Threads: 57
Joined: May 2017
13.01.2024, 23:03
(This post was last modified: 13.01.2024, 23:10 by Selur.)
Just tried here (using studio drivers 546.33).
Try disabling Fusion and CUDA Graph if you have them enabled, when I enable those it does seem to cause problems.
Just using FP16 seems to work.
Just noticed: https://github.com/HolyWu/vs-femasr is back
=> best report the problems there. (I did open an issue a while back about TensorRT now workting: https://github.com/HolyWu/vs-femasr/issues/7)
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 36
Threads: 0
Joined: Oct 2022
(13.01.2024, 23:03)Selur Wrote: Just tried here (using studio drivers 546.33).
Try disabling Fusion and CUDA Graph if you have them enabled, when I enable those it does seem to cause problems.
Just using FP16 seems to work.
Just noticed: https://github.com/HolyWu/vs-femasr is back
=> best report the problems there. (I did open an issue a while back about TensorRT now workting: https://github.com/HolyWu/vs-femasr/issues/7)
Cu Selur
As i expected.. driver releases that are so close to each other usually does not pose a problem.
Fusion & Cuda are disabled by default, so yes it only works using with fp16 checked .. the same case with me..
So, TRT is working again...
I guess i have to replace / update the addon files in hybrid folder in order to get it to work properly..
i'll check out later..
Muche obliged.
cheers,
TD
Posts: 10.598
Threads: 57
Joined: May 2017
No, that was a typo 'now' -> 'not'.
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Posts: 37
Threads: 3
Joined: Mar 2022
(13.01.2024, 16:25)Selur Wrote: Quote:Question 1: Does FineDeHalo remove the halo effect even more?
Compared to what? Against YAHR at the defaults: probably, yes.
Yes, together with YAHR. This is YAHR 1 and 16 settings plus FineDeHalo. But I must check another file if it really helps even more or maybe the improvement is very small and in the same time the footage becomes softer.
Quote:Question 2: What does the GLSL AntiRing filter do? Is it responsible for the removal of some rings and jaggies from the clip?
it should help with rings/halos and the surrounding noise, but often is more aggressive than dehalo filters.
As a side note: sometimes it helps to apply a filter multiple times.
Ok, so maybe YAHR 2x could substitute both FineDeHalo and GLSL AntiRing . It is worth checking.
Quote:I must play with a few more settings to find out "the best" ones.
do that, usually that helps to understand that there are no settings that work equally well on all sources /scenes
Cu Selur
Yes, but my "typical" AVI 640x480 files must be treated in the same way using the same settings since life is to short to deal with each file separately. Of course in the case of some more noise etc, I could use other settings.
Other sources, different approach for sure. But even now the effect is quite good vs terrible original source.
|