31.05.2024, 06:39 (This post was last modified: 31.05.2024, 06:45 by Selur.)
You entered no Mask. => nothing to do.
ProPainter:
a. needs to be in the FilterOrder (Filtering->Vapoursynth->Misc->Filter Order/Queue)
b. it need to be enabled (Filtering->Vapoursynth->Other->ProPainter)
c. a Mask need to be set (Filtering->Vapoursynth->Other->ProPainter->Mask)
Since the Mask is essential and there is no default Mask or anything like that (same with for example, Other->AddLogog, Other->GLSL, Other->VSGAN) adding a not usable entry to the Script does not make sense.
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
>>> Offline from 30th of June till 6th of July. <<<
31.05.2024, 07:20 (This post was last modified: 31.05.2024, 08:17 by Selur.)
Updated the test download.
Hybrid now adds '# Not using ProPainter, since no Mask is set' to the script, if Mask isn't set.
Cu Selur
Ps.: To get a better feel for ProPainter (what it can do, what screws to turn and where are the limitations) I opened a thread over at videohelp hoping some folks will share some short clips with watermarks&co to remove.
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
>>> Offline from 30th of June till 6th of July. <<<
Ok, now is working, yesterday I was too tired to do a decent test...
To me the implementation in Hybrid it's Ok.
I like the debug option for the mask region.
You should add an option to select a mask image or a mask clip.
In the case is selected a mask image is not more necessary to convert the image to clip, since RC4 the "mask region" is supported also on the single images.
On my PC using the single image instead of a video clip is a little faster: from 1.93fps to 1.99fps.
So there is not reason to add the conversion in clip mask.
Instead it is missing the possibility to add a mask clip. You should add it.
I added a couple of samples to use to test the clip mask.
I also attached the RC5 version. I performed only small changes: I updated the description of parameters because previously some of them were wrong.
If are not found bugs, this week-end I will release the version 1.0 in github.
Quote:I updated the description of parameters because previously some of them were wrong
might have missed some,...
main typos was on the description raft_iter
old:
Quote::param raft_iter: Iterations for RAFT inference. Low values will decrease the inference
speed but could affect the output quality. Default: 20
new:
Quote::param raft_iter: Iterations for RAFT inference. Low values will increase the inference
speed but could affect the output quality. Default: 20
Dan
(31.05.2024, 19:17)Selur Wrote: Uploaded a new test version, which allows to either use an image or a video as mask. (also the image is now directly fed to ProPainter)
The new version is Ok.
Comparing the torch package R65 with R68 I found the following (main) packages missing:
do either not work with Python 3.12 or would break some of the other installed filters by downgrading dependencies.
Sadly, I have no clue how to modify the projects themselves to be Python 3.12 compatible. HolyWu probably could modify the first four, but for example vsbasicvsrpp relies on openmim which from the looks of it does not work with anything newer than Python 3.11 atm.
=>
Do I want to add those filters: Yes
Will it happen in the near future: Unlikely
Do I think I can actively do something about it: I do not think so.
Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
>>> Offline from 30th of June till 6th of July. <<<
Since python 3.12 is braking the compatibility of some filters (you don't have included dblib which is used by code former), why you don't continue to use python 3.11 ?