This forum uses cookies
This forum makes use of cookies to store your login information if you are registered, and your last visit if you are not. Cookies are small text documents stored on your computer; the cookies set by this forum can only be used on this website and pose no security risk. Cookies on this forum also track the specific topics you have read and when you last read them. Please confirm whether you accept or reject these cookies being set.

A cookie will be stored in your browser regardless of choice to prevent you being asked this question again. You will be able to change your cookie settings at any time using the link in the footer.

DeepEnhancer
#21
BasicVSR++ is more suited to deal with compression and resizing artifacts, one of its strengthens is to repair chroma.
Spotless, DeDot and similar are more suited to remove such dirt

Don't like what DeepEnhancer does with the contrast.
For old clips, I usually prefer non-machine learning based solutions.
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Reply
#22
Selur, that was incredible work.  Thank you for the script, led me to discover why KillerSpots wasn't working for me previously, I renamed RemoveDirt.dll to RemoveDirtVS.dll to fix it
Reply
#23
Oh, will upload a new dev to fix that.
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Reply
#24
Hi Selur,

Thanks for your feedback—totally understandable regarding DeepEnhancer’s contrast handling. It does tend to be a bit aggressive and might not be the best default choice for all clips, especially if a more subtle restoration is desired.

Still, I’ve found it surprisingly effective on very old footage, particularly from the 1920s–40s, where it manages to remove large blotches and stains that even Spotless and DeDot sometimes struggle with. I agree that BasicVSR++ is great for chroma repair and compression artifacts, but DeepEnhancer seems to go further in cleaning up physical damage, even if a bit heavy-handed.

In the end, it's great to have multiple tools available depending on the situation. The flexibility Hybrid and HAVC offer makes it possible to test and choose the best one for each clip—which is a huge strength!

Thanks again for your thoughts and for keeping everything so customizable.

Best regards
Reply
#25
If you like the sharpness, you can use FeMaSR

I attached a sample with the script.

To encode this script in Hybrid you must use as encoder NVenC and enable the option  DirectSynthLoading (check also MT) in NVEnc->Misc.

Hybrid by default uses vspipe, but in this case is not possible to use it.

I opened an issue on Vapoursynth project for this: vspipe don't filter out script messages

Dan


Attached Files
.zip   Test-BasicVSR+FeMaSR.zip (Size: 2,02 MB / Downloads: 6)
Reply
#26
Didn't HolyWu fix that a while ago? (I encoded some stuff with BasicVSR++ and FeMaSR a few weeks ago without issue,.....)
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Reply
#27
If you open the script attached in the previous post and run the preview are shown the following message.

Quote:Unable to import quantization op. Please install modelopt library (https://github.com/NVIDIA/TensorRT-Model...stallation) to add support for compiling quantized models
TensorRT-LLM is not installed. Please install TensorRT-LLM or set TRTLLM_PLUGINS_PATH to the directory containing libnvinfer_plugin_tensorrt_llm.so to use converters for torch.distributed ops
D:\Programs\Hybrid\64bit\Vapoursynth\Lib\site-packages\timm\models\layers\__init__.py:48: FutureWarning: Importing from timm.models.layers is deprecated, please import via timm.layers
warnings.warn(f"Importing from {__name__} is deprecated, please import via timm.layers", FutureWarning)

these message are not filteret-out by vspipe.

The problem is on vspipe. The pipe in output should provide only the video stream. 
It is a design bug and need to be fixed on vspipe side.

Dan
Reply
#28
Ah must have done my BasicVSR++ FeMaSR encoding before I updated the torch-addon. Angel
There is always something new. Rolleyes
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Reply
#29
It can be 'fixed' with:
import logging
import sys
logging.StreamHandler(sys.stderr)
=> Uploaded a new dev which adds this to the scripts if one of the add-ons is used in the script.

Cu Selur
----
Dev versions are in the 'experimental'-folder of my GoogleDrive, which is linked on the download page.
Reply
#30
(Yesterday, 15:58)Selur Wrote: It can be 'fixed' with:
import logging
import sys
logging.StreamHandler(sys.stderr)
=> Uploaded a new dev which adds this to the scripts if one of the add-ons is used in the script.

Cu Selur

Added to the script Test-BasicVSR+FeMaSR.vpy the lines above and I put the script in input to Hybrid, still crashes.

Dan
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)