(10.06.2024, 16:48)Selur Wrote: [ -> ]@Dan64: Adjusted Hybrid to set sc_thresholds minimum to 0 when DeepEx is enabled and 0 otherwise. Through this, sc_threshold will be at least 0.01 when DeepEx is enabled.
Not checking for images when '... external ...' is used, since to do it seriously one would have to check that all images:- exist
- are really pngs
- their image resolution is correct (= matches the resolution at the place DeOldify is used)
- their naming scene is correct and the frame count fits into the current clip
=> Not doing that, since I think folks that use '... external ...' should know what they are doing. 
(updated the deolidfy test download)
Cu Selur
In the released version 4.0 I added also a control on the directory and is raised an error when the directory is specified but not valid images are found.
As stated previously I added a control also on sc_threshold so you can remove you setting to 0.01 and let the user to set the appropriate value.
If you want to keep it you should set to 0.10 when DeepEx is selected and sc_threshold =0 and sc_min_freq=0, but please allow the possibility to set it to 0 (currently cannot be below 0.01) because the reference frames can be set also using sc_min_freq.
Actually if DeepEx is deselected there is no reason to pass the parameters sc_threshold and sc_min_freq to HAVC_ddeoldify(), so these values can be left untouched because don't have to be passed to HAVC_ddeoldify().
I found a bug in the following setting
![[Image: attachment.php?aid=2550]](https://forum.selur.net/attachment.php?aid=2550)
In this case is generated the following code
Code:
# adding colors using DeOldify
from vsdeoldify import HAVC_ddeoldify
clipRef = HAVC_ddeoldify(clip=clip, deoldify_p=[0, 24, 1, 0], ddcolor_p=[1, 24, 1, 0, True], ddtweak=True, ddtweak_p=[0.0, 1.0, 2.5, True, 0.3, 0.6, 0.7, 0.5, "300:360|0.4,0.1"], sc_threshold=0.01)
from vsdeoldify import HAVC_deepex
clip = HAVC_deepex(clip=clip, clip_ref=clipRef, ref_merge=0, dark="True", smooth=True, sc_framedir="D:/PProjects/vs-deoldify_dev/TestPreset/Test10")
for some reason is filled the parameter "sc_framedir" even if in the GUI the directory box is empty.
Dan
)