Selur's Little Message Board

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92

Uploading a new torch addon,.. will be up in ~1hour.

Cu Selur

Just as a heads-up: updating to Torch 2.7 and updating torchvision breaks ColorMNet)
Noticed this when updating for dfttest2 (https://github.com/AmusementClub/vs-dfttest2/issues/8).
=> would be nice if you could update ColorMNet (the spatial_correlation_sampler stuff) to work with newer torch versions. (All other addons seems to work fine, even BasicVSR++ since it dropped the mmc dependency)

Cu Selur

Please provide the pip command used to upgrade pytorch so that I can work on the same version.

The last stable version is 2.5.1 : https://pytorch.org/get-started/locally/

I cannot recompile the correlation sample at every torch build, please change it only if really necessary.

Dan

Quote:Please provide the pip command used to upgrade pytorch so that I can work on the same version.

First I used

Code:
python -m pip install torch==2.7.0.dev20250122+cu126

like WolframRhodium suggested over at https://github.com/AmusementClub/vs-dfttest2/issues/8

Now I want to setup a new Vapoursynth torch addon where I use (for vs-rife):

Code:
pip install -U packaging setuptools wheel

pip install --pre -U torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu126

pip install --no-deps --pre -U torch_tensorrt --index-url https://download.pytorch.org/whl/nightly/cu126

pip install -U tensorrt-cu12 tensorrt-cu12_bindings tensorrt-cu12_libs --extra-index-url https://pypi.nvidia.com

which installs an even newer version. (see attachment for how I setup the torch add-on so far; still incomplete)

Quote:I cannot recompile the correlation sample at every torch build, please change it only if really necessary.

I guess there is no way to get rid of that dependency?

Since I from time to time need to update the torch-addon to support newer stuff, I need a way to get this working, ideally without you having to build it. If you could write down the instructions on how to build the correlation sample, I could do it myself whenever I need to setup a new torch-addon.

Alternatively, I would have to drop vsDeOldify since I can't install it.
I could set up a download for the last working Hybrid version with the torch-addon for that version on my filejump.com account, but I would not update vsDeOldify anymore.
(I could keep the current support for it in Hybrid, so users could still use newer versions, if the manage to add them and their dependencies to the Lib/site-packages as long as the vsDeOldify calls do not change.)

Cu Selur

Ps.: Please also check whether the Deoldify setup steps seem correct to you, thanks.

(25.01.2025, 12:43)Selur Wrote: [ -> ]Since I from time to time need to update the torch-addon to support newer stuff, I need a way to get this working, ideally without you having to build it. If you could write down the instructions on how to build the correlation sample, I could do it myself whenever I need to setup a new torch-addon.

I think that is better to explain how to build Pytorch-Correlation-extension so that you are free to install any pytorch version.

----- INSTALLATION GUIDE for: Pytorch-Correlation-extension -----

To build Pytorch-Correlation-extension it is necessary to have an installation of Microsoft Visual Studio.
I installed the version 2019. This software is necessary to compile the C/C++ code.

Then is necessary to install first the NVDIA SDK

I installed NVIDIA CUDA v12.4: cuda_12.4.0_551.61_windows.exe

during the installation select advanced options and check only CUDA (see picture)

[Image: attachment.php?aid=2917]

Then is necessary to install cuDNN, I installed the version v.8.9.7.29: cudnn-windows-x86_64-8.9.7.29_cuda12-archive.zip

This is a zip archive that need to be extracted in the same folder of CUDA SDK.
The directories to extract are: lib, include and bin.
For example in my PC I extracted the cudnn directories above in C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.4.
in this way all the cudnn dlls are stored in C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.4\bin.

After the installation you should end-up having the following environment variables defined:

CUDA_MODULE_LOADING=LAZY
CUDA_PATH=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.4
CUDA_PATH_V12_4=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.4
TORCH_CUDA_ARCH_LIST=8.6

If not you have to define them.

Then is necessary create a working folder, for example: colormnet

Next is necessary to create an environment.
I'm using conda, so the commands are the following:

Code:
conda create -n colormnet python=3.12

conda activate colormnet

cd colormnet

# you can install the desidered version by changing the command below

conda install pytorch torchvision torchaudio pytorch-cuda=12.4 -c pytorch -c nvidia

# install Pytorch-Correlation-extension

git clone https://github.com/ClementPinard/Pytorch-Correlation-extension.git 

cd Pytorch-Correlation-extension

python setup.py install

This will produce under the directory dist a egg file, like
spatial_correlation_sampler-0.5.0-py3.12-win-amd64.egg

This file have to be converted in wheel with the command (the script wheel to be installed with conda/pip)

Code:
wheel convert spatial_correlation_sampler-0.5.0-py3.12-win-amd64.egg

then is necessary to rename the generated file:

spatial_correlation_sampler-0.5.0-py3.12-win-amd64.whl

in: spatial_correlation_sampler-0.5.0-py3.12-win-amd64.whl.zip

so that is possible to open the zip archive.

The files need to be extracted in the directory (no way to install it with pip)

.\Hybrid\64bit\Vapoursynth\Lib\site-packages

Good luck!
Dan

P.S.
Please let me know if this procedure is working on your side.

Probably won't get around to test it today, but I'll give it a spin tomorrow. (will probably set up a Windows VM for this Smile

)

Cu Selur

Okay, plans changed and I ended setting up the VM. Smile

Installed Win11, Visual Studio, the NVIDIA stuff (needed to add the LAZY loading to the environment) and Anaconda3.
I then started the anaconda_prompt from the Anaconda.Navigator and started calling the listed call:

Code:
(base) C:\Users\selur>conda create -n colormnet python=3.12

Channels:

 - defaults

Platform: win-64

Collecting package metadata (repodata.json): done

Solving environment: done

## Package Plan ##

  environment location: C:\ProgramData\anaconda3\envs\colormnet

  added / updated specs:

    - python=3.12

The following packages will be downloaded:

    package                    |            build

    ---------------------------|-----------------

    bzip2-1.0.8                |       h2bbff1b_6          90 KB

    expat-2.6.4                |       h8ddb27b_0         257 KB

    libffi-3.4.4               |       hd77b12b_1         122 KB

    openssl-3.0.15             |       h827c3e9_0         7.8 MB

    pip-24.2                   |  py312haa95532_0         3.0 MB

    python-3.12.8              |       h14ffc60_0        16.4 MB

    setuptools-75.1.0          |  py312haa95532_0         2.2 MB

    sqlite-3.45.3              |       h2bbff1b_0         973 KB

    tk-8.6.14                  |       h0416ee5_0         3.5 MB

    tzdata-2025a               |       h04d1e81_0         117 KB

    vc-14.40                   |       haa95532_2          10 KB

    vs2015_runtime-14.42.34433 |       h9531ae6_2         1.2 MB

    wheel-0.44.0               |  py312haa95532_0         169 KB

    xz-5.4.6                   |       h8cc25b3_1         609 KB

    zlib-1.2.13                |       h8cc25b3_1         131 KB

    ------------------------------------------------------------

                                           Total:        36.5 MB

The following NEW packages will be INSTALLED:

  bzip2              pkgs/main/win-64::bzip2-1.0.8-h2bbff1b_6

  ca-certificates    pkgs/main/win-64::ca-certificates-2024.12.31-haa95532_0

  expat              pkgs/main/win-64::expat-2.6.4-h8ddb27b_0

  libffi             pkgs/main/win-64::libffi-3.4.4-hd77b12b_1

  openssl            pkgs/main/win-64::openssl-3.0.15-h827c3e9_0

  pip                pkgs/main/win-64::pip-24.2-py312haa95532_0

  python             pkgs/main/win-64::python-3.12.8-h14ffc60_0

  setuptools         pkgs/main/win-64::setuptools-75.1.0-py312haa95532_0

  sqlite             pkgs/main/win-64::sqlite-3.45.3-h2bbff1b_0

  tk                 pkgs/main/win-64::tk-8.6.14-h0416ee5_0

  tzdata             pkgs/main/noarch::tzdata-2025a-h04d1e81_0

  vc                 pkgs/main/win-64::vc-14.40-haa95532_2

  vs2015_runtime     pkgs/main/win-64::vs2015_runtime-14.42.34433-h9531ae6_2

  wheel              pkgs/main/win-64::wheel-0.44.0-py312haa95532_0

  xz                 pkgs/main/win-64::xz-5.4.6-h8cc25b3_1

  zlib               pkgs/main/win-64::zlib-1.2.13-h8cc25b3_1

Proceed ([y]/n)? y

Downloading and Extracting Packages:

Preparing transaction: done

Executing transaction: done

#

# To activate this environment, use

#

#     $ conda activate colormnet

#

# To deactivate an active environment, use

#

#     $ conda deactivate

(base) C:\Users\selur>conda activate colormnet

(colormnet) C:\Users\selur>cd colormnet

Das System kann den angegebenen Pfad nicht finden.

Did something go wrong, or do I need to change to ' C:\ProgramData\anaconda3\envs\colormnet' ? Smile

Cu Selur

Another question: Is this correct with the cuda version&co ?
Shouldn't I have used v12.6 ? Since for vs-rife I installed from https://download.pytorch.org/whl/nightly/cu126 ?

Sorry I forgot the step of creating the working folder (don't forget to install also Visual Studio).
You can create a working folder with any name, in this case it is just necessary to install Pytorch-Correlation-extension source code to compile.
I suggested to call it with the name colorment since is used by colorment but any name is Ok.

I'm happy that you have discovered the location of colormnet environment on you Windows installation.

To be sure, after having installed the pytorch stuff, I override the conda environment (in this case C:\ProgramData\anaconda3\envs\colormnet')
with exactly the same pytorch packages installed in Hybrid, this should guarantee the maximun compatibility.

Dan

Code:
(base) PS C:\ProgramData\anaconda3\envs\colormnet> git clone https://github.com/ClementPinard/Pytorch-Correlation-extension.git

Cloning into 'Pytorch-Correlation-extension'...

remote: Enumerating objects: 262, done.

remote: Counting objects: 100% (124/124), done.

remote: Compressing objects: 100% (80/80), done.

remote: Total 262 (delta 81), reused 55 (delta 42), pack-reused 138 (from 1)

Receiving objects: 100% (262/262), 74.44 KiB | 3.10 MiB/s, done.

Resolving deltas: 100% (156/156), done.

(base) PS C:\ProgramData\anaconda3\envs\colormnet> git clone https://github.com/ClementPinard/Pytorch-Correlation-extension.git ^C

(base) PS C:\ProgramData\anaconda3\envs\colormnet> cd .\Pytorch-Correlation-extension\

(base) PS C:\ProgramData\anaconda3\envs\colormnet\Pytorch-Correlation-extension> python setup.py install

No CUDA runtime is found, using CUDA_HOME='C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.4'

running install

C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\cmd.py:79: SetuptoolsDeprecationWarning: setup.py install is deprecated.

!!

        ********************************************************************************

        Please avoid running ``setup.py`` directly.

        Instead, use pypa/build, pypa/installer or other

        standards-based tools.

        See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.

        ********************************************************************************

!!

  self.initialize_options()

C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\cmd.py:79: EasyInstallDeprecationWarning: easy_install command is deprecated.

!!

        ********************************************************************************

        Please avoid running ``setup.py`` and ``easy_install``.

        Instead, use pypa/build, pypa/installer or other

        standards-based tools.

        See https://github.com/pypa/setuptools/issues/917 for details.

        ********************************************************************************

!!

  self.initialize_options()

running bdist_egg

running egg_info

creating Correlation_Module\spatial_correlation_sampler.egg-info

writing Correlation_Module\spatial_correlation_sampler.egg-info\PKG-INFO

writing dependency_links to Correlation_Module\spatial_correlation_sampler.egg-info\dependency_links.txt

writing requirements to Correlation_Module\spatial_correlation_sampler.egg-info\requires.txt

writing top-level names to Correlation_Module\spatial_correlation_sampler.egg-info\top_level.txt

writing manifest file 'Correlation_Module\spatial_correlation_sampler.egg-info\SOURCES.txt'

C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\utils\cpp_extension.py:537: UserWarning: Attempted to use ninja as the BuildExtension backend but we could not find ninja.. Falling back to using the slow distutils backend.

  warnings.warn(msg.format('we could not find ninja.'))

reading manifest file 'Correlation_Module\spatial_correlation_sampler.egg-info\SOURCES.txt'

adding license file 'LICENSE'

writing manifest file 'Correlation_Module\spatial_correlation_sampler.egg-info\SOURCES.txt'

installing library code to build\bdist.win-amd64\egg

running install_lib

running build_py

creating build\lib.win-amd64-cpython-312\spatial_correlation_sampler

copying Correlation_Module\spatial_correlation_sampler\spatial_correlation_sampler.py -> build\lib.win-amd64-cpython-312\spatial_correlation_sampler

copying Correlation_Module\spatial_correlation_sampler\__init__.py -> build\lib.win-amd64-cpython-312\spatial_correlation_sampler

running build_ext

C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\utils\cpp_extension.py:422: UserWarning: Error checking compiler version for cl: [WinError 2] Das System kann die angegebene Datei nicht finden

  warnings.warn(f'Error checking compiler version for {compiler}: {error}')

C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\utils\cpp_extension.py:456: UserWarning: The detected CUDA version (12.4) has a minor version mismatch with the version that was used to compile PyTorch (12.6). Most likely this shouldn't be a problem.

  warnings.warn(CUDA_MISMATCH_WARN.format(cuda_str_version, torch.version.cuda))

building 'spatial_correlation_sampler_backend' extension

creating build\temp.win-amd64-cpython-312\Release\Correlation_Module

"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -DUSE_CUDA -IC:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\include -IC:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\include\torch\csrc\api\include -IC:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\include\TH -IC:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\include\THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.4\include" -IC:\ProgramData\anaconda3\include -IC:\ProgramData\anaconda3\Include "-IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\ATLMFC\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\um" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\shared" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\winrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\cppwinrt" /EHsc /TpCorrelation_Module\correlation.cpp /Fobuild\temp.win-amd64-cpython-312\Release\Correlation_Module\correlation.obj /MD /wd4819 /wd4251 /wd4244 /wd4267 /wd4275 /wd4018 /wd4190 /wd4624 /wd4067 /wd4068 /EHsc -std=c++17 -fopenmp -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=spatial_correlation_sampler_backend -D_GLIBCXX_USE_CXX11_ABI=0 /std:c++17

cl : Befehlszeile warning D9002 : Unbekannte Option "-std=c++17" wird ignoriert.

cl : Befehlszeile warning D9002 : Unbekannte Option "-fopenmp" wird ignoriert.

correlation.cpp

C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\utils\cpp_extension.py:2069: UserWarning: TORCH_CUDA_ARCH_LIST is not set, all archs for visible cards are included for compilation.

If this is not desired, please set os.environ['TORCH_CUDA_ARCH_LIST'].

  warnings.warn(

Traceback (most recent call last):

  File "C:\ProgramData\anaconda3\envs\colormnet\Pytorch-Correlation-extension\setup.py", line 69, in <module>

    launch_setup()

  File "C:\ProgramData\anaconda3\envs\colormnet\Pytorch-Correlation-extension\setup.py", line 37, in launch_setup

    setup(

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\__init__.py", line 117, in setup

    return distutils.core.setup(**attrs)

           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\core.py", line 186, in setup

    return run_commands(dist)

           ^^^^^^^^^^^^^^^^^^

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\core.py", line 202, in run_commands

    dist.run_commands()

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\dist.py", line 983, in run_commands

    self.run_command(cmd)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\dist.py", line 999, in run_command

    super().run_command(command)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\dist.py", line 1002, in run_command

    cmd_obj.run()

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\command\install.py", line 109, in run

    self.do_egg_install()

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\command\install.py", line 167, in do_egg_install

    self.run_command('bdist_egg')

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\cmd.py", line 339, in run_command

    self.distribution.run_command(command)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\dist.py", line 999, in run_command

    super().run_command(command)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\dist.py", line 1002, in run_command

    cmd_obj.run()

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\command\bdist_egg.py", line 177, in run

    cmd = self.call_command('install_lib', warn_dir=False)

          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\command\bdist_egg.py", line 163, in call_command

    self.run_command(cmdname)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\cmd.py", line 339, in run_command

    self.distribution.run_command(command)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\dist.py", line 999, in run_command

    super().run_command(command)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\dist.py", line 1002, in run_command

    cmd_obj.run()

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\command\install_lib.py", line 19, in run

    self.build()

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\command\install_lib.py", line 110, in build

    self.run_command('build_ext')

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\cmd.py", line 339, in run_command

    self.distribution.run_command(command)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\dist.py", line 999, in run_command

    super().run_command(command)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\dist.py", line 1002, in run_command

    cmd_obj.run()

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\command\build_ext.py", line 99, in run

    _build_ext.run(self)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\command\build_ext.py", line 365, in run

    self.build_extensions()

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\utils\cpp_extension.py", line 908, in build_extensions

    build_ext.build_extensions(self)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\command\build_ext.py", line 481, in build_extensions

    self._build_extensions_serial()

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\command\build_ext.py", line 507, in _build_extensions_serial

    self.build_extension(ext)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\command\build_ext.py", line 264, in build_extension

    _build_ext.build_extension(self, ext)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\command\build_ext.py", line 562, in build_extension

    objects = self.compiler.compile(

              ^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\utils\cpp_extension.py", line 803, in win_wrap_single_compile

    return original_compile(sources, output_dir, macros,

           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\setuptools\_distutils\_msvccompiler.py", line 455, in compile

    self.spawn(args)

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\utils\cpp_extension.py", line 784, in spawn

    cflags = win_cuda_flags(cflags) + ['-std=c++17', '--use-local-env']

             ^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\utils\cpp_extension.py", line 738, in win_cuda_flags

    cflags + _get_cuda_arch_flags(cflags))

             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\selur\AppData\Roaming\Python\Python312\site-packages\torch\utils\cpp_extension.py", line 2089, in _get_cuda_arch_flags

    arch_list[-1] += '+PTX'

    ~~~~~~~~~^^^^

IndexError: list index out of range

Any idea what a sensibe value to set TORCH_CUDA_ARCH_LIST to would be? (Pascal?)
(Attached the created whl file)
Cu Selur

Selur

Selur

Dan64

Selur

Dan64

Selur

Selur

Selur

Dan64

Selur