Updated ColorMatrix structure looks nice.
I noticed two inactive (probably missing .dylib?) plug-ins Retinex and HDR10 to SDR (DG)
---
Here is some thoughts about naming. It looks like in most apps Rec. 709 or 601 definition used to describe unchanged Rec. 709 or 601 color/matrix/transfer/ specification in common. But when it goes to customized separate parts like custom color/matrix/transfer, usually (but not always) used name BT.709 (similar to x265 "bt709" and other tags logic currently used in Hybrid components)
So maybe arrange names in Hybrid ColorMatrix based on Media Info naming:
Color primaries : BT.601 PAL
colour_primaries_Original : BT.601 NTSC
Transfer characteristics : BT.709
Matrix coefficients : BT.601
Okay,... if you want the transfer characteristics form Filtering->Vapoursynth->Color->ColorMatriy->Transfer to be changed I need suggestions for the names
http://www.vapoursynth.com/doc/functions/resize.html uses:
- 709
- 470m
- 470bg
- 601
- 240m
- linear
- log100
- log316
- xvycc
- srgb
- 2020_10
- 2020_12
- st2084
- std-b67
not more not less.
If you want other things changed I need specific references to the GUI and specific translation.
Note that this requires quite some code changes (that can break a LOT) since so if you are not precise my best option is to simply ignore what you post.
Do not rely on names given by MediaInfo, they tend to change form time to time without any mention of the changes inside the changelogs, so this always causes problems. Also Hybrid does not always (just) use MediaInfo.
Cu Selur
No one in any app or industry just never use those lower case code names. They are visible only on low level x264/265 FFmpeg settings and may give a lot of confusion to basic users. I don't see any problems with current Media info names understanding. I will arrange normal renaming list for you.
Can you provide Color spaces list from ColorMatrix as well?
Here is for Color-> ColorMatrix -> Transfer:
709 -> BT.709
470m -> BT.470 System M
470bg -> BT.470 System B/G
601 -> BT.601
240m -> SMPTE 240M
linear -> Linear
log100 -> Log (100:1)
log316 -> Log (316.22777:1)
xvycc -> xvYCC
srgb -> sRGB
2020_10 -> BT.2020 (10-bit)
2020_12 -> BT.2020 (12-bit)
st2084 -> PQ
std-b67 -> HLG
Quote:Can you provide Color spaces list from ColorMatrix as well?
Yes I can, but be aware that I won't change those names any time soon.
Since changing those will break stuff unless quite a few lines of code are adjusted, since Hybrid needs to translate those for each tool into supported values. (atm. Hybrid doesn't care about the transfer characteristics, aside from passing it through from the input)
If you change the transfer, you should make sure you also signal it properly in the VUI settings of the encoder you use, assuming it has such settings.
ColorMatrix use:
Code:
values << QString("Rec.709");
values << QString("FCC");
values << QString("Rec.601/470bg/470m");
values << QString("SMPTE 170m");
values << QString("SMPTE 240m");
values << QString("YCoCg");
values << QString("Rec.2020ncl");
values << QString("Rec.2020cl");
values << QString("Chroma ncl");
values << QString("Chroma cl");
values << QString("ICtCp");
for 'From' and 'To'.
Cu Selur
Here is a list, but if it is not a simple "display name" changing and if it break things, maybe no need to change it? I guess no need to hurry and learn things better. Pretty names are useless if they break system stability.
Rec.709 -> BT.709
FCC -> FCC 73.682
Rec.601/470bg/470m -> BT.601 PAL
SMPTE 170m -> BT.601 NTSC
SMPTE 240m -> SMPTE 240M
YCoCg -> YCoCg
Rec.2020ncl -> BT.2020 non-constant
Rec.2020cl -> BT.2020 constant
Chroma ncl -> Chroma non-constant
Chroma cl -> Chroma constant
ICtCp -> ICtCp
What about other places?
x264 -> VUI
x265 -> Signaling
ProRes VUI
Config -> MKV tagging
By the way Matroska system use it's own naming - sort of human friendly display names combined code tag names. not so bad...)
![[Image: OepMa2J.jpg]](https://i.imgur.com/OepMa2J.jpg)
![[Image: 9wdyJdL.jpg]](https://i.imgur.com/9wdyJdL.jpg)
![[Image: DoB5RLW.jpg]](https://i.imgur.com/DoB5RLW.jpg)
I won't change anything else atm.
All this cosmetic stuff might be nice, but it's stuff that should be done after at least all the tools Hybrid uses are available and normal bugs are fixed.
Atm. Hybrid uses:
* and uploaded it to google drive
Working on getting AV1 support working on MacOS atm.
Cu Selur
- Updated ffdcaenc visible in Hybrid Tools list instead of old dcaenc
- Render mp3 audio track works. But it always produce Joint Stereo M/S MP3 and i can't see any option in UI to switch it to normal stereo. Not sure if Joint Stereo on/off switch missing due update because i never used MP3 audio for video track.
- Updated VS viewer works
Filtering -> ColorMatrix filter (non Vaporsynth) is broken after redesign. Probably because both ColorMatrix filters where somehow connected.
[qutoe]Render mp3 audio track works. But it always produce Joint Stereo M/S MP3 and i can't see any option in UI to switch it to normal stereo. Not sure if Joint Stereo on/off switch missing due update because i never used MP3 audio for video track[/quote]
Nope, there never was such switch since no one ever asked for it and I haven't use mp3 for 20+years.
Quote:Filtering -> ColorMatrix filter (non Vaporsynth) is broken after redesign. Probably because both ColorMatrix filters where somehow connected.
I'll look at it, it's probably missing a connection between model and gui.
Cu Selur
Joint Stereo is worst possible option for MP3 compression
It was designed to increase compression by interleaving stereo channels.
So,..? I don't tell people what they should do or not.
I also don't tell everyone who uses DNxHD or ProRes instead of a really lossless format while editing and repeatedly saving their results that they do a not so wise thing since each iteration will cause further loss,...
-> unless someone asks for it I won't look into it.
Hybrid gets a new feature is either someone asks for it or I want it for some reason.
Wildly adding features that nobody asks for seems like a bad idea.
Quote:It was designed to increase compression by interleaving stereo channels.
Which by itself isn't a bad idea. And if you use low data rates it makes sense to use it. Same with HE-AAC and HE-AACv2, both make sense for low data rates and not so much for high data rates.
Cu Selur